Fix admin dashboard query count CI failure - #328
Merged
Conversation
Co-authored-by: Lucas Parzianello <lucaspar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_dashboard_context().Verification
just test-py sds_gateway/tests/test_admin_dashboard.py::test_dashboard_context_query_count(blocked:justis not installed in this runner).uv run --extra local pytest sds_gateway/tests/test_admin_dashboard.py::test_dashboard_context_query_count(blocked:uvis not installed in this runner).Note
Low Risk
Test-only change with no production or security impact.
Overview
Updates
test_dashboard_context_query_countso the bounded-query guard matches what_dashboard_context()actually runs today.The test comment now lists nine expected queries (capture/dataset counts, top users, recent users, superusers, total users, health snapshot, plus file aggregates), and
max_queriesis raised from 8 to 9 so CI no longer fails when that context is built.Reviewed by Cursor Bugbot for commit d2f7da7. Bugbot is set up for automated code reviews on this repo. Configure here.