Skip to content

Fix gateway sites app CI migration conflict - #330

Merged
lucaspar merged 1 commit into
masterfrom
cursor/continuous-integration-failures-cfff
Jul 31, 2026
Merged

Fix gateway sites app CI migration conflict#330
lucaspar merged 1 commit into
masterfrom
cursor/continuous-integration-failures-cfff

Conversation

@cursor

@cursor cursor Bot commented Jul 31, 2026

Copy link
Copy Markdown

Fixes the gateway CI deploy failure caused by registering the copied sites package as a second Django app. The custom sites AppConfig now wraps Django's native sites app, and settings no longer installs sds_gateway.contrib.sites as a duplicate local app.

Verification:

  • Static configuration sanity check passed (sds_gateway.contrib.sites.apps.SitesConfig replaces django.contrib.sites; duplicate local app removed).
  • Full Django/Docker verification could not be run in this cloud image because uv, Django, and Docker are unavailable.
Open in Web View Automation 

Note

Medium Risk
Touches Django app registration and migrations for sites, which affects Auth0/allauth Site lookups; behavior should be equivalent but deploy/migrate ordering should be verified.

Overview
Fixes gateway CI deploy failures from registering the custom sites package as a second Django app alongside django.contrib.sites.

Settings: django.contrib.sites is replaced by sds_gateway.contrib.sites.apps.SitesConfig in DJANGO_APPS, and sds_gateway.contrib.sites is removed from LOCAL_APPS so only one sites app is installed. MIGRATION_MODULES still points sites at sds_gateway.contrib.sites.migrations.

App config: SitesConfig now subclasses Django’s SitesConfig (instead of a separate AppConfig with label sds_gateway_sites), calls super().ready(), and keeps the existing post_migrate hook that syncs Site(id=SITE_ID) from SITE_DOMAIN.

Reviewed by Cursor Bugbot for commit 322d7a3. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-authored-by: Lucas Parzianello <lucaspar@users.noreply.github.com>
@semanticdiff-com

semanticdiff-com Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review changes with  SemanticDiff

Changed Files
File Status
  gateway/sds_gateway/contrib/sites/apps.py  16% smaller
  gateway/config/settings/base.py  0% smaller

@lucaspar
lucaspar marked this pull request as ready for review July 31, 2026 23:38
@lucaspar
lucaspar merged commit 4819bde into master Jul 31, 2026
2 checks passed
@lucaspar
lucaspar deleted the cursor/continuous-integration-failures-cfff branch July 31, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants