Fix gateway sites app CI migration conflict - #330
Merged
Conversation
Co-authored-by: Lucas Parzianello <lucaspar@users.noreply.github.com>
Changed Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the gateway CI deploy failure caused by registering the copied sites package as a second Django app. The custom sites AppConfig now wraps Django's native
sitesapp, and settings no longer installssds_gateway.contrib.sitesas a duplicate local app.Verification:
sds_gateway.contrib.sites.apps.SitesConfigreplacesdjango.contrib.sites; duplicate local app removed).uv, Django, and Docker are unavailable.Note
Medium Risk
Touches Django app registration and migrations for
sites, which affects Auth0/allauth Site lookups; behavior should be equivalent but deploy/migrate ordering should be verified.Overview
Fixes gateway CI deploy failures from registering the custom sites package as a second Django app alongside
django.contrib.sites.Settings:
django.contrib.sitesis replaced bysds_gateway.contrib.sites.apps.SitesConfiginDJANGO_APPS, andsds_gateway.contrib.sitesis removed fromLOCAL_APPSso only onesitesapp is installed.MIGRATION_MODULESstill pointssitesatsds_gateway.contrib.sites.migrations.App config:
SitesConfignow subclasses Django’sSitesConfig(instead of a separateAppConfigwith labelsds_gateway_sites), callssuper().ready(), and keeps the existingpost_migratehook that syncsSite(id=SITE_ID)fromSITE_DOMAIN.Reviewed by Cursor Bugbot for commit 322d7a3. Bugbot is set up for automated code reviews on this repo. Configure here.