Add OpenBao Variable Provider - #3719
Open
thorstenhans wants to merge 1 commit into
Open
thorstenhans wants to merge 1 commit into
thorstenhans wants to merge 1 commit into
Conversation
Signed-off-by: Thorsten Hans <thans@akamai.com>
Contributor
|
Is there any difference between the two implementations? If not then perhaps this could just be a |
Contributor
|
or rename everything |
Contributor
Author
|
@lann 🤦🏻 yeah.. obviously the way smarter approach for the implementation. Haven't considered that as an feasible approach... Let' me test locally before refactoring it in that way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying
vaultrsallows us connecting to Vault and OpenBao. I've added dedicated provider and shared the impl between Vault and OpenBao.Although this being mainly sugar coating on top of the already existing implementation, it's worth it IMO. OpenBao is a truly community driven alternative under the CNCF umbrella umbrella besides Vault that should be supported.