Parameterize Azure Cosmos key-value queries - #3720
Merged
itowlson merged 1 commit intoSep 17, 2026
Merged
Conversation
Keys and store ids were interpolated into the Cosmos SQL text, so a key containing a single quote could break out of the literal and read or match other rows. Bind them as query parameters instead. Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
itowlson
approved these changes
Sep 17, 2026
Contributor
|
Nice! Thanks for finding this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keys and store ids were interpolated into the Cosmos SQL text, so a key containing
'could break out of the literal and read or match other rows. This binds them as query parameters viaQuery::with_paramsinstead.Verified against a live Cosmos DB container through
get,exists,get_keys,get_many,incrementand compare-and-swap with quoted and injection-shaped keys.