Support Gradle's configuration cache - #478
Open
DragonFSKY wants to merge 1 commit into
Open
Conversation
Closes spring-iogh-461 Signed-off-by: dragonfsky <dragonfsky@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-461
CheckFormat currently accesses Task.project during task execution when it builds the formatting-violation message. Gradle configuration-cache validation rejects that access.
This change injects ProjectLayout into CheckFormat and uses its project directory to preserve the existing project-relative violation paths without accessing Task.project at execution time. It also adds a Gradle 9.1 TestKit regression that runs the failing check twice, verifies that the violation is still reported, and confirms that the second run reuses the configuration cache.
Tests: