Repository navigation
refactor: Flatten config maps and introduce RoleBuilder - #887
Merged
Merged
Conversation
adwk67
marked this pull request as ready for review
October 13, 2026 13:59
siegfriedweber
self-requested a review
October 19, 2026 09:35
siegfriedweber
requested changes
Oct 29, 2026
adwk67
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of https://github.com/stackabletech/internal-issues/issues/167
Overview of logic flow
%%{init: {"flowchart": {"wrappingWidth": 900, "htmlLabels": true}}}%% flowchart TB START["`**build()** mod.rs:160`"] START --> LCO START --> LBR START --> LHI START --> LMM START --> LRO subgraph coordinator_track["Coordinator"] direction TB LCO["`**build_pdb()** :166 · **build_group_listener()** :169 **loop** over coordinator_role_group_configs :175`"] RCO["`**coordinator::build()** role_group/coordinator.rs:30 **heap_memory()** :45 · no direct memory **RoleGroupInputs { .. }** :47 listener: Some :58 · role_jvm_args: Derby log :64 · oidc_enabled: true :66`"] LCO --> RCO end subgraph broker_track["Broker"] direction TB LBR["`**build_pdb()** :184 · **build_group_listener()** :187 **loop** over broker_role_group_configs :193`"] RBR["`**broker::build()** role_group/broker.rs:22 **heap_memory()** :38 · 400 MiB direct memory :37 **RoleGroupInputs { .. }** :40 listener: Some :51 · oidc_enabled: true :58`"] LBR --> RBR end subgraph historical_track["Historical"] direction TB LHI["`**build_pdb()** :202 · no listener **loop** over historical_role_group_configs :205`"] RHI["`**historical::build()** role_group/historical.rs:29 **HistoricalDerivedSettings::try_from()** :44 · heap + direct from memory limit **segment_cache_locations()** :50 · resource_runtime_properties **RoleGroupInputs { .. }** :54 listener: None · role_pod_volumes: segment cache :66 · role_druid_mounts :67 · oidc_enabled: true :72`"] LHI --> RHI end subgraph middle_manager_track["MiddleManager"] direction TB LMM["`**build_pdb()** :214 · no listener **loop** over middle_manager_role_group_configs :221`"] RMM["`**middle_manager::build()** role_group/middle_manager.rs:56 **heap_memory()** :71 · no direct memory **RoleGroupInputs { .. }** :73 listener: None · **indexer_java_opts()** :90 · **drain_pre_stop_hook()** :98 · oidc_enabled: false :106`"] LMM --> RMM end subgraph router_track["Router"] direction TB LRO["`**build_pdb()** :230 · **build_group_listener()** :233 **loop** over router_role_group_configs :239`"] RRO["`**router::build()** role_group/router.rs:22 **heap_memory()** :38 · 128 MiB direct memory :37 **RoleGroupInputs { .. }** :40 listener: Some :51 · oidc_enabled: true :58`"] LRO --> RRO end RCO --> NEW RBR --> NEW RHI --> NEW RMM --> NEW RRO --> NEW NEW["`**RoleGroupBuilder::new(inputs)** role_group/mod.rs:163 · resolve, same for every role **config_map_data()** resource/config_map.rs:118 · runtime.properties layers: resource_runtime_properties :141, TLS :262, auth with oidc_enabled :266, indexer_java_opts :278, role_runtime_defaults :281, configOverrides :282 · jvm.config: **construct_jvm_args()** :297 with role_jvm_args :301 · security.properties: indexer_java_opts :314 **containers_and_volumes()** container.rs:107 · prepare :117, druid :118 with druid_pre_stop :121, role_druid_mounts :179, role_pod_volumes :181, listener PVC + mount if listener :186, Vector :333`"] NEW --> ADD["`**RoleGroupResources::add()** mod.rs:284 · emit **build_services()** role_group/mod.rs:190 · headless + metrics Service **build_config_map()** resource/config_map.rs:343 · wraps builder.config_map_data **build_statefulset()** resource/statefulset.rs:41 · affinity :48, grace period :51, pod_volumes :59, init_containers :83, containers :87, pod overrides :92, volume_claim_templates :113`"] ADD --> OUT["`**KubernetesResources { .. }** mod.rs:260 PDBs and Listeners from the role level above · **build_discovery_configmap()** :255 · **build_service_account()** :266 · **build_role_binding()** :267`"] OUT --> APPLY["`**apply()** controller.rs:155 · outside build/`"] classDef coordinator fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a classDef broker fill:#fde68a,stroke:#b45309,color:#78350f classDef historical fill:#bbf7d0,stroke:#15803d,color:#14532d classDef middle_manager fill:#fbcfe8,stroke:#be185d,color:#831843 classDef router fill:#ddd6fe,stroke:#6d28d9,color:#4c1d95 classDef shared fill:#e5e7eb,stroke:#4b5563,color:#111827 classDef edge fill:#ffffff,stroke:#6b7280,color:#111827,stroke-dasharray:4 2 class LCO,RCO coordinator class LBR,RBR broker class LHI,RHI historical class LMM,RMM middle_manager class LRO,RRO router class NEW,ADD,OUT shared class START,APPLY edge style coordinator_track fill:#eff6ff,stroke:#93c5fd style broker_track fill:#fffbeb,stroke:#fcd34d style historical_track fill:#f0fdf4,stroke:#86efac style middle_manager_track fill:#fdf2f8,stroke:#f9a8d4 style router_track fill:#f5f3ff,stroke:#c4b5fdTests (one a little flakey which passed on the second attempt):
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker