Skip to content

feat: allow disabling containerdebug for SparkApplications - #801

Closed
akarsh11111111 wants to merge 1 commit into
stackabletech:mainfrom
akarsh11111111:fix/containerdebug-opt-out-730
Closed

akarsh11111111 wants to merge 1 commit into
stackabletech:mainfrom
akarsh11111111:fix/containerdebug-opt-out-730

Conversation

@akarsh11111111

Copy link
Copy Markdown

Description

Add a default-on spec.containerDebug.enabled setting to SparkApplication. Setting it to false disables the containerdebug startup command in submit, driver, and executor containers while retaining the Spark environment bootstrap hook. SparkApplicationTemplate inheritance, generated CRDs, usage documentation, and the Unreleased changelog are updated.

Closes #730

Validation:

  • cargo fmt --all -- --check — passed.
  • git diff --check — passed.
  • YAML parsing of extra/crds.yaml and checks of both SparkApplication schemas — passed.
  • cargo test -p stackable-spark-k8s-operator container — blocked on Windows before reaching this crate's tests: stackable-operator imports Unix-only tokio::signal::unix.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

Closes stackabletech#730

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@stackable-cla

stackable-cla Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@akarsh11111111

Copy link
Copy Markdown
Author

Hi maintainers ,I am akarsh ! I have signed the CLA. Since this is my first time contributing on your repo ,the GitHub Actions workflows are currently awaiting approval to run.

Also, just a heads up: I couldn’t run the Rust tests locally because I’m developing on Windows and the stackable-operator dependency imports Unix-only tokio::signal::unix. I verified that the generated CRD YAML parses and that both SparkApplication schemas include the new setting. I’ll rely on the CI pipeline for the Rust test results once the workflows are approved.

Please let me know if you’d like any changes before or after the CI runs. Thanks!

@lfrancke

lfrancke commented Nov 5, 2026

Copy link
Copy Markdown
Member

Thanks for raising the PR.

I'm going to close it in favor of our ongoing work to make this configurable in the entire platform instead: stackabletech/issues#884

@lfrancke lfrancke closed this Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable verbose containerdebug logging in Spark Kubernetes operator

2 participants