Repository navigation
feat: allow disabling containerdebug for SparkApplications - #801
akarsh11111111 wants to merge 1 commit into
Conversation
Closes stackabletech#730 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Hi maintainers ,I am akarsh ! I have signed the CLA. Since this is my first time contributing on your repo ,the GitHub Actions workflows are currently awaiting approval to run. Also, just a heads up: I couldn’t run the Rust tests locally because I’m developing on Windows and the stackable-operator dependency imports Unix-only tokio::signal::unix. I verified that the generated CRD YAML parses and that both SparkApplication schemas include the new setting. I’ll rely on the CI pipeline for the Rust test results once the workflows are approved. Please let me know if you’d like any changes before or after the CI runs. Thanks! |
|
Thanks for raising the PR. I'm going to close it in favor of our ongoing work to make this configurable in the entire platform instead: stackabletech/issues#884 |
Description
Add a default-on
spec.containerDebug.enabledsetting to SparkApplication. Setting it tofalsedisables the containerdebug startup command in submit, driver, and executor containers while retaining the Spark environment bootstrap hook. SparkApplicationTemplate inheritance, generated CRDs, usage documentation, and the Unreleased changelog are updated.Closes #730
Validation:
cargo fmt --all -- --check— passed.git diff --check— passed.extra/crds.yamland checks of both SparkApplication schemas — passed.cargo test -p stackable-spark-k8s-operator container— blocked on Windows before reaching this crate's tests:stackable-operatorimports Unix-onlytokio::signal::unix.Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker