test: rename the env fixture token to an obviously synthetic value - #61
Merged
Conversation
envRejectedOverlayModel took its GITHUB_TOKEN fixture from the shape rejectedOverlayModel used before b4e86c7 renamed it — mixed-case alphanumerics that read as high entropy. GitGuardian scans the PR's commits, so the new one raised a second finding, and a false positive there is a manual triage in the dashboard rather than something the repo can settle. Every other token fixture in the suite is an obviously fake lowercase word — ghp_notarealtoken, ghp_refusedtoken, ghp_deadbeef, ghp_expired. This one joins them. No test reads the value: TestAPIStatusNudgeIsEnvAware asserts on the nudge row, not on the masked token line. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #60. This commit was pushed to the branch a few minutes before the merge, but GitHub had not registered the new head yet, so #60 merged at
31797e7and left it behind. No CI ever ran on it.envRejectedOverlayModeltook itsGITHUB_TOKENfixture from the shaperejectedOverlayModelused beforeb4e86c7renamed it — mixed-case alphanumerics that read as high entropy. GitGuardian scans a PR's commits, so it raised a second finding, and a false positive there is a manual triage in the dashboard rather than something the repo can settle.Every other token fixture in the suite is an obviously fake lowercase word —
ghp_notarealtoken,ghp_refusedtoken,ghp_deadbeef,ghp_expired. This one joins them.No behavior change and no test reads the value:
TestAPIStatusNudgeIsEnvAwareasserts on the nudge row, not on the masked token line. Verified locally withgo build/go vet/go test -race ./internal/model//golangci-lint run(0 issues).