fix: center title-only toast content - #175
Merged
Merged
Conversation
Owner
|
Thanks for fixing the toast alignment and adding the preview and regression coverage! Nice attention to detail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A title-only toast such as “Saved” sits above its status icon and dismiss button. The row always uses top alignment: the title has a 20px line height, the controls are 28px high, and the icon has an additional 2px top margin.
Center the row and remove the icon offset when neither a description nor an action is present. Toasts with descriptions or actions keep their current top alignment. Add a persistent “Title only” preview, update the component date, and cover updating an existing toast from detailed content to a title only.
Reproduction
Before this change, the icon center is 6px below the title center. All three elements should share a vertical center.
Validation
bun run checkpassed: TypeScript, Biome lint, and all 82 registry components.bun testpassed: 424 tests, including 6 toast regression cases. The title-only, empty-description, and details-removed cases failed before the fix.