Skip to content

Fix #2601 parse single-leg findAndRerank sorts - #2647

Open
erichare wants to merge 5 commits into
mainfrom
feat/rerank-single-leg-sort-parsing
Open

erichare wants to merge 5 commits into
mainfrom
feat/rerank-single-leg-sort-parsing

Conversation

@erichare

@erichare erichare commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

What this PR does:

This adds request parsing for findAndRerank sorts containing just $vectorize, $vector, or $lexical. It does not enable those searches yet. Execution support is separate work in #2602. Existing $hybrid requests keep their current behavior.

Which issue(s) this PR fixes:

Refs #2601 and #2602. Neither issue is closed by this PR. The rerankCandidateLimit option and field sorts remain out of scope.

Verification:

Passed on Java 21 with 104 tests, no failures, errors, or skips. Formatting and git diff --check origin/main...HEAD passed. Full unit and database integration suites were not run.

JAVA_HOME=/Library/Java/JavaVirtualMachines/graalvm-21.jdk/Contents/Home ./mvnw clean fmt:check -Dtest=FindAndRerankSortClauseDeserializerTest,FindAndRerankPlannerTest,FindAndRerankRequestTest test
JAVA_HOME=/Library/Java/JavaVirtualMachines/graalvm-21.jdk/Contents/Home ./mvnw fmt:check -Dtest=FindAndRerankSortClauseDeserializerTest,FindAndRerankPlannerTest,FindAndRerankRequestTest test
git diff --check origin/main...HEAD

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@erichare
erichare requested a review from a team as a code owner October 15, 2026 17:22
@erichare
erichare force-pushed the feat/rerank-single-leg-sort-parsing branch from e0f8b5a to d72fe81 Compare November 4, 2026 01:42
@erichare
erichare changed the base branch from fix/rerank-candidate-pagination to main November 4, 2026 01:53
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

📈 Unit Test Coverage Delta vs Main Branch

Metric Value
Main Branch 56.74%
This PR 57.06%
Delta 🟢 +0.32%
✅ Coverage improved!

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

Overall Project 57.06% -0.12% 🍏
Files changed 89.1% 🍏

File Coverage
FindAndRerankSortClauseDeserializer.java 99.56% 🍏
FindAndRerankPlanner.java 88.77% -10.99% 🍏
FindAndRerankSort.java 88.48% -8.79% 🍏
SortExpression2.java 87.06% -12.94% 🍏

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

📉 Integration Test Coverage Delta vs Main Branch (dse69-it)

Metric Value
Main Branch 72.98%
This PR 72.67%
Delta 🔴 -0.31%
⚠️ Coverage decreased

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (dse69-it)

Overall Project 72.67% -0.7% 🍏
Files changed 35.77% ❌

File Coverage
FindAndRerankSortClauseDeserializer.java 60.7% -31.66% ❌
FindAndRerankPlanner.java 57.13% -35.63% ❌
FindAndRerankSort.java 22.42% -74.85% ❌
SortExpression2.java 0% ❌

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

📉 Integration Test Coverage Delta vs Main Branch (hcd-it)

Metric Value
Main Branch 74.33%
This PR 74.10%
Delta 🔴 -0.23%
⚠️ Coverage decreased

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (hcd-it)

Overall Project 74.1% -0.59% 🍏
Files changed 45.34% ❌

File Coverage
FindAndRerankPlanner.java 71.5% -27.78% ❌
FindAndRerankSortClauseDeserializer.java 67.47% -25.33% 🍏
FindAndRerankSort.java 28.79% -68.48% ❌
SortExpression2.java 0% ❌

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants