Repository navigation
Conversation
waskyo
left a comment
There was a problem hiding this comment.
High-level comment: instead of waiting until we're about to run the preprocessor to grab the already preprocessed file, could you check for that beforehand and avoid the function call altogether?
Or maybe this functionality could be added as a wrapper to the existing functions instead of inside of the functions themselves?
|
I had it inline so that we could reuse the logic that prints out status/copys the file into the appropriate place and avoid having to change all the sites that call it, I can change this to a wrapper if you think that's better, moving the copyfile and verbose logging out to that? Any opinions on what to call the wrapper and then what to rename this to? (preprocess and preprocess_with_xxx)? Also should we worry about all or nothing (only use the preprocessed files if they're all available, or use the ones that are available and regenerate any that are missing?) |
No description provided.