Skip to content

Add commandline to search for preprocessed files. - #86

Open
dvorak42 wants to merge 2 commits into
static-analysis-engineering:masterfrom
dvorak42:preprocessor_cmd
Open

dvorak42 wants to merge 2 commits into
static-analysis-engineering:masterfrom
dvorak42:preprocessor_cmd

Conversation

@dvorak42

@dvorak42 dvorak42 commented Nov 4, 2026

Copy link
Copy Markdown

No description provided.

@waskyo waskyo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High-level comment: instead of waiting until we're about to run the preprocessor to grab the already preprocessed file, could you check for that beforehand and avoid the function call altogether?

Or maybe this functionality could be added as a wrapper to the existing functions instead of inside of the functions themselves?

@dvorak42

dvorak42 commented Nov 4, 2026

Copy link
Copy Markdown
Author

I had it inline so that we could reuse the logic that prints out status/copys the file into the appropriate place and avoid having to change all the sites that call it, I can change this to a wrapper if you think that's better, moving the copyfile and verbose logging out to that? Any opinions on what to call the wrapper and then what to rename this to? (preprocess and preprocess_with_xxx)?

Also should we worry about all or nothing (only use the preprocessed files if they're all available, or use the ones that are available and regenerate any that are missing?)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants