Update kdtree and fix KDE radius - #444
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #444 +/- ##
==========================================
+ Coverage 95.07% 95.39% +0.31%
==========================================
Files 62 65 +3
Lines 14203 15069 +866
==========================================
+ Hits 13504 14375 +871
+ Misses 699 694 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan includes up to 3 reviews per rolling hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe optional ChangesDensity radius and dependency updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The dependency and KDE radius changes present no actionable merge-blocking risk in the supplied evidence; the PR is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Motivation
kdtree0.8.1 intentionally changedwithin()to return unordered results in mrhooray/kdtree-rs#85. The existing KDE and KNN implementations used the last result as the neighborhood radius, which produces incorrect densities after the dependency update.Changes
kdtreefrom 0.7.0 to 0.8.1Refs:
#428
Summary by CodeRabbit
Bug Fixes
Maintenance
Tests