Skip to content

chore: clean up mixed Chartist imports #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stklcode merged 1 commit into from
Sep 13, 2026
Merged

chore: clean up mixed Chartist imports #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [unreleased]

### Changed
- Clean up mixed Chartist imports

----

## [2.0.0] - 18th April 2026

### Changed
Expand Down
9 changes: 4 additions & 5 deletions src/scripts/chartist-plugin-tooltip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import * as Chartist from 'chartist';
import {BarChart, BaseChart, PieChart, PieChartOptions} from 'chartist';
import {extend, BarChart, BaseChart, PieChart, PieChartOptions} from 'chartist';

/**
* Tooltip plugin options.
Expand Down Expand Up @@ -62,7 +61,7 @@ export default function ChartistPluginTooltip<T extends BaseChart<any>>(
chart: T,
options?: Partial<Options>
): void {
const defaultOptions = {
const defaultOptions: Options = {
tooltipOffset: {
x: 0,
y: -20
Expand All @@ -76,7 +75,7 @@ export default function ChartistPluginTooltip<T extends BaseChart<any>>(
metaIsHTML: false
};

const $options = Chartist.extend({}, defaultOptions, options) as Options;
const $options: Options = extend({}, defaultOptions, options);

// Warning: If you are using npm link or yarn link, these instanceof checks will fail and you won't get any tooltips
let tooltipSelector = $options.pointClass || '';
Expand Down Expand Up @@ -132,7 +131,7 @@ export default function ChartistPluginTooltip<T extends BaseChart<any>>(
let tooltipText = '';

let seriesName = '';
if (chart instanceof Chartist.BarChart) {
if (chart instanceof BarChart) {
seriesName =
(point.parentNode as HTMLElement).getAttribute('ct:meta') ||
(point.parentNode as HTMLElement).getAttribute('ct:series-name') ||
Expand Down