Bump dependencies, clean CMake, small headers update#155
Merged
Conversation
Upgrade dependency versions: cpp-library 5.2.0→5.4.1, copy-on-write 1.1.0→1.1.1, and Boost 1.90.0→1.91.0-1 (updated URL and SHA). Clean up CMake whitespace/formatting and fix Doxygen target configuration spacing. Remove unused #include <adobe/fnv.hpp> from adobe/name.hpp and replace <vector> with <array> in test/to_string/main.cpp to match usage.
There was a problem hiding this comment.
Pull request overview
This PR updates third-party dependency versions and performs small cleanup changes to keep build/test code aligned with actual usage and improve CMake readability.
Changes:
- Bumped CPM dependencies:
stlab/cpp-libraryto 5.4.1,stlab/copy-on-writeto 1.1.1, and Boost to 1.91.0-1 (with updated URL/SHA). - Cleaned CMake formatting/whitespace, including the documentation (Doxygen) configuration block.
- Removed/adjusted includes to match usage (
<vector>→<array>in a test, removed unusedadobe/fnv.hppinclude).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CMakeLists.txt | Updates dependency versions and tidies formatting in core build + docs configuration. |
| adobe/name.hpp | Removes an unused include to reduce header dependencies. |
| test/to_string/main.cpp | Switches to <array> to match actual buffer usage in std::to_chars test helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…d test files - Removed unnecessary includes from parser_shared.cpp, virtual_machine.cpp, xml_parser.cpp, xstring.cpp, zuid.cpp, and zuid_sys_dep.cpp. - Cleaned up test files by eliminating redundant includes and organizing header files for better readability. - Added NOLINT comments for include cleaner in various test files to maintain code quality. - Improved code consistency and reduced compilation time by streamlining header dependencies.
- Removed unused includes from `forest.hpp`, `future.hpp`, and `iomanip_asl_cel.hpp`. - Simplified copy constructor and assignment operator in `forest_iterator` by using default implementations. - Added missing include for `<algorithm>` in `future.cpp`. - Removed unused function `throw_variable_not_defined` from `virtual_machine.cpp`. - Updated the initialization of `empty_uuid` in `zuid.cpp` for better clarity. - Cleaned up `functional_test.cpp` by removing unnecessary comments and simplifying enum definitions. - Removed unused `print_binary_message` and `validate` functions from `bench.cpp`. - Added a new file `GlobalCompilationDatabase.cpp` to implement global compilation database functionality.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 85 out of 85 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
test/closed_hash/main.cpp:16
- The second NOLINT tag is misspelled (
misc-inlucde-cleaner), so it won’t match clang-tidy’smisc-include-cleanercheck. Also, having two NOLINTs here is redundant; keep a single correctly spelled suppression.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 86 out of 86 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
test/closed_hash/main.cpp:16
- The second NOLINT tag has a typo (
misc-inlucde-cleaner) and the line currently carries duplicate NOLINT annotations. This makes the intent unclear and can leave clang-tidy warnings unsuppressed if the wrong check name is used elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade dependency versions: cpp-library 5.2.0→5.4.1, copy-on-write 1.1.0→1.1.1, and Boost 1.90.0→1.91.0-1 (updated URL and SHA). Clean up CMake whitespace/formatting and fix Doxygen target configuration spacing. Remove unused #include <adobe/fnv.hpp> from adobe/name.hpp and replace with in test/to_string/main.cpp to match usage.