Skip to content

build(mpv): turn off sixel, dvdnav and x11 so the build machine cannot leak them in - #6

Open
morganp wants to merge 1 commit into
streamyfin:avfoundation-ao-tvosfrom
morganp:build/disable-host-features
Open

morganp wants to merge 1 commit into
streamyfin:avfoundation-ao-tvosfrom
morganp:build/disable-host-features

Conversation

@morganp

@morganp morganp commented Oct 29, 2026

Copy link
Copy Markdown

Description

Names four mpv features as disabled in the build options: sixel, dvdnav, x11 and x11-clipboard.

mpv auto-detects these through pkg-config. On a machine that has Homebrew's libsixel, libdvdnav, libdvdread and libx11 installed, a local iOS build compiled vo_sixel, stream_dvdnav and the X11 clipboard backend. The app then failed to link, with about 140 unresolved symbols such as _sixel_encode, _dvdnav_* and _XOpenDisplay. None of these exist on iOS or tvOS.

The GitHub runner has none of those libraries, so CI output should not change. This only makes a local build match CI whatever is installed on the machine.

How it was tested

  • A local iOS only MPVKit build with these options, on a Mac with all four Homebrew libraries installed. The resulting framework has no _sixel_, _dvdnav_ or _X* undefined symbols, and the app linked and ran on an iPad.
  • Before the change, the same machine produced a framework that failed to link.

Not verified

  • A CI run of this branch. The change should be a no-op there, but I have not confirmed that the produced binary is identical.
  • tvOS, macOS and the other slices. I only built the iOS slice.
  • Whether other auto features in mpv could leak in the same way. I only found these four.

AI assisted: drafted and tested with Claude Code.

🤖 Generated with Claude Code

https://claude.ai/code/session_01BsaHcCXUsC4JTpKgBe2AgJ

…t leak them in

mpv auto-detects these through pkg-config. With Homebrew's libsixel,
libdvdnav, libdvdread and libx11 installed, a local iOS build compiled
vo_sixel, stream_dvdnav and the X11 clipboard backend, and the app then
failed to link against the missing symbols. None of them exist on iOS or
tvOS, so name them as disabled.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BsaHcCXUsC4JTpKgBe2AgJ
@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: bcac1ea0-2803-4096-a7cb-a40cc8824e1b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant