Repository navigation
Conversation
…t leak them in mpv auto-detects these through pkg-config. With Homebrew's libsixel, libdvdnav, libdvdread and libx11 installed, a local iOS build compiled vo_sixel, stream_dvdnav and the X11 clipboard backend, and the app then failed to link against the missing symbols. None of them exist on iOS or tvOS, so name them as disabled. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BsaHcCXUsC4JTpKgBe2AgJ
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Names four mpv features as disabled in the build options:
sixel,dvdnav,x11andx11-clipboard.mpv auto-detects these through
pkg-config. On a machine that has Homebrew'slibsixel,libdvdnav,libdvdreadandlibx11installed, a local iOS build compiledvo_sixel,stream_dvdnavand the X11 clipboard backend. The app then failed to link, with about 140 unresolved symbols such as_sixel_encode,_dvdnav_*and_XOpenDisplay. None of these exist on iOS or tvOS.The GitHub runner has none of those libraries, so CI output should not change. This only makes a local build match CI whatever is installed on the machine.
How it was tested
_sixel_,_dvdnav_or_X*undefined symbols, and the app linked and ran on an iPad.Not verified
autofeatures in mpv could leak in the same way. I only found these four.AI assisted: drafted and tested with Claude Code.
🤖 Generated with Claude Code
https://claude.ai/code/session_01BsaHcCXUsC4JTpKgBe2AgJ