Repository navigation
Add Reporting Chart component to GA - #251
Merged
Merged
Conversation
Preserve the preview API with height and load callbacks. Accept Date values in the setter hook so report intervals can be forwarded. Require Connect.js 3.5.0 and bump the React GA package to 3.5.0. Cover prop forwarding, updates, clearing, and initialization with tests. Validation: yarn test && yarn build passed. Committed-By-Agent: goose Orbit-Session-Id: 15c72c97-d3fc-4328-8cbb-e71dfcf96774
Removed the redundant update test, which repeated setter-forwarding assertions without exercising React’s update lifecycle, and reused the populated-props fixture. Reverted unrelated formatting churn while preserving the security-related comment removal. Required behavior is unchanged, with meaningful coverage retained for every prop’s setter, optional-prop clearing, and initialization. Component tests, lint, TypeScript checks, and git diff --check passed. Committed-By-Agent: goose Orbit-Session-Id: 15c72c97-d3fc-4328-8cbb-e71dfcf96774
Committed-By-Agent: goose Orbit-Session-Id: 15c72c97-d3fc-4328-8cbb-e71dfcf96774
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Committed-By-Agent: claude Orbit-Session-Id: eabdb56a-04a3-4d30-b4f3-da140f86eb34
torrance-stripe
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Reporting Chart component to GA folder
Bumps version to
3.5.0and ensuresconnect-jspeer dependency is above3.5.0