You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor: improve and cleanup (unused) code - #788
No actionable comments were generated in the recent review.
Summary
Summary by CodeRabbit
API Changes
Removed the Ktor configuration type and several public schema-model APIs, including data-loader utilities and query-type lookup. Applications relying on these APIs may need updates.
Refactor
Streamlined schema and query processing while preserving the resulting type collections and path components.
Bug Fixes
Updated subscription argument handling and playground resource loading. Also refined asynchronous test timing and execution.
Schema construction and runtime code now use updated collection and iteration patterns. Several model API declarations and the Ktor configuration class are removed. Ktor playground resource loading and test support are updated.
Changes: Core schema and runtime
Layer / File(s)
Summary
Schema type construction and validation kgraphql-ktor-stitched/.../StitchedSchemaCompilation.kt, kgraphql/src/main/.../MutableSchemaDefinition.kt, kgraphql/src/main/.../SchemaCompilation.kt
Schema compilation and stitched schema compilation build type or field collections with list builders. Type-name checks inspect the relevant collections directly. Built-in enum definitions use enumEntries.
Execution and utility updates kgraphql/src/main/.../Execution.kt, kgraphql/src/main/.../ParallelRequestExecutor.kt, kgraphql/src/main/.../ast/Location.kt, kgraphql/src/main/.../blockString.kt, kgraphql/src/test/.../DataLoaderTest.kt
Execution path construction, subscription argument collection, and utility iteration are updated. Loader construction uses the enclosing coroutine scope's job. Tests use explicit millisecond durations, and simpleChild runs its blocking sleep on Dispatchers.IO.
Model API removals kgraphql/src/main/.../schema/model/DataLoader.kt, kgraphql/src/main/.../schema/model/Deprecation.kt, kgraphql/src/main/.../schema/structure/SchemaModel.kt, kgraphql/api/kgraphql.api
The DataLoader implementation and related declarations, Deprecation, SchemaModel.queryTypesByName, and corresponding published API declarations are removed. Definition remains in the API.
Ktor configuration and test support
Layer / File(s)
Summary
Ktor configuration and playground resource loading kgraphql-ktor/api/kgraphql-ktor.api, kgraphql-ktor/src/main/.../KtorGraphQLConfiguration.kt, kgraphql-ktor/src/main/.../KtorFeature.kt, kgraphql-ktor/src/test/.../KtorMultipleEndpointsTest.kt
KtorGraphQLConfiguration and its published API declaration are removed. The feature and test load playground.html through GraphQL's class loader.
Ktor test query builder updates kgraphql-ktor/src/test/.../Kraph.kt
The test query builder removes the String and Int variable overloads. Its field and variable iteration now uses forEach.
Change: Refactor
Merge Risk: Minimal · previous review 2a731
This is a cleanup refactor with no identified behavior change or merge-blocking issue. Public API removals are intended and no problems were found with them.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title uses the conventional commits prefix "refactor:" and is 43 characters, under the 50-character guideline. It says the PR refactors code and removes unused code, which matches the changeset: r…
Description check
The description lists the PR's main changes: avoiding list creation, using collection builders, removing unused classes, functions and properties, and replacing map with forEach. These match the file-…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title uses the conventional commits prefix "refactor:" and is 43 characters, under the 50-character guideline. It says the PR refactors code and removes unused code, which matches the changeset: removal of unused classes such as DataLoader, Deprecation, and KtorGraphQLConfiguration, plus collection-builder and forEach changes in several files.
Full details: Description check
Explanation
The description lists the PR's main changes: avoiding list creation, using collection builders, removing unused classes, functions and properties, and replacing map with forEach. These match the file-level changes in the summary, such as buildList in SchemaCompilation, removed DataLoader.kt and Deprecation.kt, and forEach in Location.kt and Kraph.kt.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
❌ Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.26%. Comparing base (59ad2b2) to head (08c15b1).
Mainly:
- Avoid list creation if not required
- Otherwise, use collection builders to reduce amount of intermediate
lists
- Remove unused classes, functions and properties
- Replace `map` with `forEach` when return value was not used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Bencher Report
Mainly:
mapwithforEachwhen return value was not used