docs: trim stale native-image CI note in AGENTS.md#1000
Merged
bestbeforetoday merged 2 commits intoJul 16, 2026
Merged
Conversation
The per-PR native-image job no longer builds the macOS image and no longer depends on the java/integration jobs, so the "macOS native image is the PR long pole" guidance is stale. Reflect the current setup: PRs build the Linux native image only (with --quick-build-native, in parallel with the other jobs), while the macOS native image is built out-of-band in native-image-macos.yml on push to main, a weekly schedule, and workflow_dispatch.
nielspardon
requested review from
andrew-coleman,
benbellick,
bestbeforetoday and
vbarua
July 10, 2026 05:50
Member
|
The information all looks correct to me. I wonder how useful it is to aid an AI agent in developing code. Is it worth taking up more of the context window with this information or would it be more effective to just remove it? |
Per review feedback: the expanded guidance mostly documented the absence of a gotcha (substrait-io#997 removed the macOS long-pole from PRs) and duplicated what pr.yml already states. Keep only the non-obvious residual: macOS native regressions surface on main/weekly, not on the PR.
nielspardon
changed the title
Member
Author
|
Good push — agreed. As the thing this file is written for, I'll say the note was low value: it's guidance loaded into context every session, so it should earn its keep, and this one didn't. Two reasons beyond the general context-window cost:
So rather than remove it outright, I trimmed it to the one residual fact that isn't obvious and that actually changes behavior: macOS native isn't built per-PR, so those regressions land on |
bestbeforetoday
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trims the AGENTS.md note about monitoring the native-image CI job down to the one durable, non-obvious fact.
The note originally existed to warn contributors/agents that a PR staying yellow was usually just waiting on the slow macOS
Build Isthmus Native Imagelong-pole job. #997 removed that long pole — the per-PR native build is now Linux only, uses--quick-build-native, and runs in parallel with thejava/integrationjobs. So most of what the note (and my first pass at updating it) described was either the absence of a gotcha or detail already spelled out inpr.yml.Per @bestbeforetoday's review feedback — this is guidance loaded into an agent's context every session, so it should earn its keep — I cut it to the single fact that isn't easily discoverable and that changes behavior:
Docs-only; no code or workflow behavior is affected.
🤖 Generated with AI