You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Polish approval cards after the v0.3.0 review #176
Finish the remaining third- and fourth-level findings from the image-only approval card review for v0.3.0 (#169). None of them blocks the release.
Context
The third-round review of PR #175 (9670fa8) found no first- or second-level problems. These remain:
R1: after a cancelled Touch ID on a 30-minute request, the card offers only "re-authenticate, allow for 30 minutes" and deny. Add "re-authenticate, allow once".
R2: cards don't say that the requester already knows the values it provides. "Kept in Ask Key only, never given to agents" reads as if the value were secret from the requester. Section headings also count unchanged items as provided by the requester.
R3: Chinese line breaks split 凭证 and leave one- or two-character last lines (10, 16).
R4: on the merge step, the main line became an explanation, and 对它隐藏 is unclear. The existing-group count reads awkwardly.
R5: 删掉了 lists tiny word fragments. Added text relies on color alone.
R6: a same-length value replacement looks unchanged at a glance.
Goal
Finish the remaining third- and fourth-level findings from the image-only approval card review for v0.3.0 (#169). None of them blocks the release.
Context
The third-round review of PR #175 (
9670fa8) found no first- or second-level problems. These remain:The review reports and images stay outside the repository; this list is self-contained.
Scope
Approval card views and copy (
Sources/AskKeyAppKit/App/Approval*.swift,Frozen*Approval*.swift,FrozenWriteSummaryContent.swift),Localizable.xcstrings, App tests, screenshot scenarios. Display only.Acceptance
swift build; filtered tests; hygiene and module checks; CI green; a planner re-render with an image-only review shows no regressions.Blocked by
#173.