Repository navigation
Lead the READMEs with the website's pitch, in each language's own screenshots - #187
Merged
Merged
Conversation
…ominent The optional screenshot run also captures the approval prompt and the Agent access page in Simplified Chinese, for README.zh-CN.md. Each README now carries a large badge right under its title that links to the other language.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs plus one optional screenshot test; no app code.
AskKey.dmg, data directory, keychain service) stayAskKey.README.zh-CN.mdnow shows Chinese screenshots:assets/readme/approval-prompt-zh.pngandassets/readme/agent-access-zh.png.ScreenshotE2ETests.testReadmeScreensInChinesecaptures them in the optional screenshot run withASKKEY_E2E_LANGUAGE=zh-Hansas18-zh-approval-defaultand19-zh-agent-access;scripts/e2e-report.pyexports both, anddocs/testing.mdlists all 19 screenshots.Image source
From the
askkey-basic-ui-evidenceartifact of CI run 38426263004:18-zh-approval-default.png(300×364) and19-zh-agent-access.png(980×652). Processed like the English images in #151: the Agent access window's empty 32 px bottom strip cropped to 980×620, and the corners outside the rounded window made transparent with the English images' own alpha. Synthetic data only.Checks
python3 scripts/check_hygiene.pyandpython3 -m unittest discover -s Tests/Automation: passed.build-and-testandbasic-ui-flowspassed, and the optional screenshot run exported all 19 PNGs.scripts/run-e2e.shwas not run locally.