Skip to content

Competitive-Coding-10 completed - #456

Open
sathvikareddy18 wants to merge 1 commit into
super30admin:masterfrom
sathvikareddy18:master
Open

Competitive-Coding-10 completed#456
sathvikareddy18 wants to merge 1 commit into
super30admin:masterfrom
sathvikareddy18:master

Conversation

@sathvikareddy18

Copy link
Copy Markdown

No description provided.

@super30admin

Copy link
Copy Markdown
Owner

Strengths:

  • The "buy_sell_stock_II.py" solution is concise and efficiently captures the problem's requirements.
  • The "peeking_iterator.py" implementation is correct and follows good practices with docstrings and clear logic.
  • Both solutions have optimal time and space complexity.

Areas for Improvement:

  • While the "buy_sell_stock_II.py" solution is correct, it would be beneficial to add a brief comment explaining the logic, especially for someone unfamiliar with the problem.
  • In "peeking_iterator.py", the docstring for the peek method is misplaced (it appears after the method definition). It should be placed before the method definition for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants