Skip to content

Completed Coding-10 - #457

Open
Saideepthi123 wants to merge 1 commit into
super30admin:masterfrom
Saideepthi123:master
Open

Completed Coding-10#457
Saideepthi123 wants to merge 1 commit into
super30admin:masterfrom
Saideepthi123:master

Conversation

@Saideepthi123

Copy link
Copy Markdown

No description provided.

@super30admin

Copy link
Copy Markdown
Owner
  • Strengths:

    • The student has demonstrated a good understanding of the problems and provided efficient solutions.
    • The comments and explanations are clear and helpful in understanding the logic.
    • The code is well-structured and follows best practices.
  • Areas for Improvement:

    • In the maxProfit solution, the initial comment about the "dp check" approach is a bit confusing since the solution doesn't use dynamic programming. It might be better to clarify that the solution uses a greedy approach.
    • The PeekingIterator solution could include a brief comment explaining the overall strategy (e.g., "Maintain a next_element to enable peeking without advancing the iterator").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants