Disable Vale.Terms to stop false-positive casing errors#2432
Merged
Conversation
Vale 3.15.1 (used in CI) enforces the casing of every accept.txt vocab term via Vale.Terms, including inside code spans and code blocks, and prints regex vocab entries verbatim as the suggested fix. This produces 450 findings across 216 files, nearly all false positives, and turns the Vale check red on unrelated PRs whenever they touch an affected file. Vale.Spelling and Vale.Repetition are already disabled for similar reasons; the vocab still serves spelling acceptance via Fly.Spelling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vale.Termsauto-derives from ouraccept.txtvocab and enforces the canonical casing of every term. Vale 3.15.1 (the version CI installs viaerrata-ai/vale-action) runs it aggressively:`fly scale vm`,[[vm]]), where the lowercase form is required and can't be changed.VM('s)?\borconfigs?\b, it prints the raw regex as the suggested replacement ("Use 'VM('s)?\b' instead of 'vm'").Across the docs this is 450 findings in 216 files, nearly all false positives. Because the Vale workflow lints whole changed files (
filter_mode: file) and reviewdog exits non-zero on any finding, this turns the Vale check red on unrelated PRs the moment they touch an affected file (most recently #2192).This disables
Vale.Terms, consistent withVale.SpellingandVale.Repetition, which are already off. The vocab still does its main job of spelling acceptance throughFly.Spelling, so no terms become misspellings.