fix(emotion): merge target/label into non-object-literal styled() options - #648
Conversation
styled('div', someIdentifier) and styled('div', config.opts) emitted the
generated options as a THIRD argument. @emotion/styled reads only two, so
the target was silently dropped and ${Component} selectors broke at
runtime with no build-time signal.
Non-object-literal options now spread into the injected options object,
the same treatment call expressions already received.
🦋 Changeset detectedLatest commit: 05d8404 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05d8404c3b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| props.extend(args_props); | ||
| } | ||
| Expr::Call(_) => { | ||
| _ => { |
There was a problem hiding this comment.
When the second argument is itself spread, such as styled("div", ...args)(styles), this arm replaces only its expression while retaining ExprOrSpread.spread. The emitted call becomes styled("div", ...{ target, label, ...args }), and attempting to spread that non-iterable object into the call throws at runtime. Check and handle the argument's spread marker before applying this wrapper; the mirrored tagged-template path has the same issue.
Useful? React with 👍 / 👎.
2 participants
When
styled(tag, options)gets an identifier or member expression as options, the transform appendstarget/labelas an extra argument instead of merging:The component silently loses its selector target, so
${Card}component selectors break at runtime.#202 already fixed this for call expressions (#201); this completes it for the remaining non-literal shapes by giving the
_arm the same spread-wrap treatment, at both injection sites.styled-non-literal-options— fails on main, passes with the fix.issues/201output byte-identical; full crate suite + wasm tests green; fmt/clippy clean.