Repository navigation
Conversation
The stricter stubs reject what the kernel rejects as well: - The SSE Client now registers Active, URL and Headers itself (symcon/SymconStubs#80), registering them again via reflection fails. - ConnectParent() already connects configurator and devices, so the tests take the existing connection instead of calling IPS_ConnectInstance() again. Green with symcon/SymconStubs#80; against 31f2e04 alone the SSE data flow, the string association list and SetBuffer() with an integer still fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stubs became much stricter with symcon/SymconStubs#78 and #79. This raises the submodule to 31f2e04 and adapts the tests. The module itself is unchanged.
prepareParentIo()no longer registersActive,URLandHeaderson the SSE Client. The stub registers them itself now and only allows registrations inCreate().ConnectParent()already connects the configurator and the devices. The tests take that connection instead of callingIPS_ConnectInstance()again, which the kernel rejects as well.The CI stays red until symcon/SymconStubs#80 is merged. Against 31f2e04 alone, the SSE data flow, the string association list and
SetBuffer()with an integer still fail. With #80 all tests pass, and I'll raise the submodule once it is merged.