Repository navigation
[SymForce] Reject constant inputs in Codegen - #478
Open
devteamaegis wants to merge 1 commit into
Open
devteamaegis wants to merge 1 commit into
devteamaegis wants to merge 1 commit into
Conversation
Codegen accepted inputs whose elements were constants or expressions rather than symbols, e.g. Values(a=sf.Rot3.from_storage([1, 2, 3, 4])), and generated a function with an argument that is never used. Raise a ValueError naming the offending input keys instead. Fixes symforce-org#170
Author
|
Friendly ping @aaron-skydio: this is ready for review whenever someone has time (fixes #170); happy to make changes. This was investigated and written with an AI coding agent (Claude) working on my behalf. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #170.
Codegenaccepted inputs that weren't symbols, for exampleValues(a=sf.Rot3.from_storage([1, 2, 3, 4])), and generated a function whose argument has no effect. The constructor now checks that every storage element of every input is ansf.Symboland raisesValueError: Inputs must be symbolic, found constants or expressions in: ['a']otherwise. DataBuffers andNoneinputs store as empty lists, so they're unaffected.Tests: added cases to
test_invalid_codegen_raisesfor constant inputs, an expression input (x * y) and a vector mixing a symbol and a constant. They fail onmainand pass with this change. The rest of the Python test suite gives the same results as onmain, andruff check/ruff format --checkare clean.