Repository navigation
1.11.4 : MBS <-> WCS correctness, refactoring, and performance (part 1) - #88
Open
synesissoftware wants to merge 7 commits into
Open
synesissoftware wants to merge 7 commits into
synesissoftware wants to merge 7 commits into
Conversation
Add unit tests for the components that still call `mbstowcs()` / `wcstombs()` directly: - `multibyte2wide` / `wide2multibyte`, wide `exception_string_creator`, and the `error_desc_w` fallback; - `ACE_Time_Value` wide shims, writing the non-`ACE_USES_WCHAR` conversion at the start of the destination buffer;
mwsis
approved these changes
Oct 28, 2026
Write the non-`ACE_USES_WCHAR` `mbstowcs()` result at the start of the destination, and call `mbstowcs_s()` / `wcstombs_s()` from the rejection oracles when `STLSOFT_USING_SAFE_STR_FUNCTIONS` is set: - **include/acestl/shims/access/string/time_value.hpp**; - **test.unit.stlsoft.conversion.char_conversions**; - **test.unit.stlsoft.util.exception_string_creator**;
synesissoftware
marked this pull request as ready for review
October 28, 2026 02:10
Add **test.unit.stlsoft.std.type_info**. Narrow shims are `type_info::name()`, and the wide shims match an ASCII widening of that name: - `c_str_data_w`, `c_str_len_w`, `c_str_ptr_w`, and `c_str_ptr_null_w`;
Add **test.unit.stlsoft.std.exception**. Narrow shims are `exception::what()`, and the wide shims match an ASCII widening of that message. An empty `what()` yields an empty wide string and a null `c_str_ptr_null_w`: - `c_str_data_w`, `c_str_len_w`, `c_str_ptr_w`, and `c_str_ptr_null_w`;
synesissoftware
changed the title
mwsis
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.