Repository navigation
feat: AGC2 adaptive digital gain in realtime microphone processing - #15
Merged
Merged
Conversation
RealtimeAudioProcessing gets a third prewarmed WebRTC processor with gain_controller2.adaptive_digital, reachable through processGain(). It is a separate call so the application can measure its own gate level after AEC/NS and before gain. AEC and NS processing is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (5)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For syrnike13-app issue #165: replace the application's hand-written gain with WebRTC AGC2.
RealtimeAudioProcessing::processGain()— one 10 ms frame through a prewarmed APM withgain_controller2.adaptive_digital(C ABI inlivekit-ffi/src/realtime_apm.rs).process()so the caller can take its gate measurement after AEC/NS and before gain.process()is unchanged.Verification (local, Windows):
cargo test -p livekit-ffi --lib realtime_apm::tests(2),ctest -R AudioProcessingModuleTest(33, incl. a test that quiet speech-like input is raised). App-side offline measurement with SAPI speech: quiet mic -27 → -22 dBFS, SNR unchanged.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.