Skip to content

feat: anisotropic Čech filtration value and gradient for ellipsoid simplices (ported from ellcech) - #140

Draft
uda-lab-agent wants to merge 29 commits into
ellphi-0.1.3from
project26-manybody-dev
Draft

uda-lab-agent wants to merge 29 commits into
ellphi-0.1.3from
project26-manybody-dev

Conversation

@uda-lab-agent

@uda-lab-agent uda-lab-agent commented Oct 4, 2026 •

Copy link
Copy Markdown
Collaborator

Governing issue: uda-lab/project-ellphi#26 (private). Do not merge: the owner will decide the target release branch and give explicit merge approval; until then this PR stays open for review. Based on ellphi-0.1.3 only because that is the current development branch; the base will be retargeted when the owner names the release.

What this adds

  • ellphi.cech(coefs, ...) -> CechResult(t, point, mu, support, active_set): the anisotropic Čech filtration time for k packed ellipsoids. For a simplex sigma, t^2 = alpha(sigma) = min_x max_i f_i(x), the least squared scale at which the growing ellipsoids E_i(t) = {f_i <= t^2} share a common point. point is the critical common intersection point x*, mu are the Lagrange multipliers (dual weights on the simplex), support is thresholded multiplier support, and active_set is the tight-constraint set. Non-convergence or non-finite output raises RuntimeError.
  • ellphi.cech_grad(coefs, ...) -> CechGrad(t, point, mu, dt_dcoef, support, active_set): coefficient-space gradient of the Čech filtration time. The gradient is dt/dcoef_i = mu_i · basis(point) / (2t), including the constant component.
  • At the critical scale the intersection is the single point x*. The active ellipsoid boundaries pass through x* with sum_i mu_i grad f_i(x*) = 0, so the normals are positively dependent; the boundaries are not tangent to each other. For k = 2 the Čech time equals the tangency time computed by tangency(), and cech() agrees with it.
  • The derivative documentation preserves the hypotheses: non-degenerate input, at least two active indices, multipliers supported on the active set, and an exact weighted linear solve with an additional floating-point residual. Convergence or a small residual alone is not a derivative certificate.
  • The private minimax engine retains its internal module names and provenance. The public module is ellphi.cech; tests are in tests/test_cech.py and the guide is docs/guide/cech_filtration.md.

Settled owner numerical contract (2026-10-05)

This is the acceptance direction for this PR; implementation compliance still requires commit-scoped review and tests.

  • Named solver functions / explicitly selected methods: detect when the declared calculation has not succeeded and raise a meaningful, diagnosable exception. Never silently invoke another solver contrary to the advertised solver/method name. Explicitly declared hybrids may perform their stated stages, with accurate naming and diagnostics.
  • Composite/default library layer: design a fast, high-accuracy best-effort route for ordinary, reasonably expected valid inputs. Reasonable fallback routes are permitted at this separate layer when the actual methods used, original failures, transitions and final outcome are externally traceable. An unidentified fallback or generic catch-all that masks failure is unacceptable.
  • Responsibility and limits: users supply valid inputs and may choose another method after an explicit failure. The library is not required to rescue every extreme case. Do not sacrifice ordinary-input speed or accuracy through ad hoc non-mathematical patches or engineering tricks aimed at universal corner-case success. Existing difficult two-body EllPHi tests reflect mature, tractable methods and do not establish an all-solvers/all-cases many-body requirement.

Review/test ordinary-input speed and achieved accuracy; meaningful failure behavior and named-method fidelity; and, separately, any composite/default fallback triggers, route visibility, final checks and total cost. Retain bounded boundary/conditioning/degeneracy tests with explicit expected success or failure behavior. An honest exception can satisfy a failure-behavior test but is still a failure in numerical-success reporting.

Keep the narrowed value/status fidelity gate separate from derivative guarantees. A success flag or small gap does not certify derivative accuracy; retain separate derivative evidence and the documented support, locality, nondegeneracy and linear-solve hypotheses.

FW remains a provisional candidate, not an owner preference or mandated default, warm-up or fallback. This clarification selects no default, replacement method, tolerance or acceptance-rate target. Earlier review replies saying “no automatic fallback” must be read under this layer-specific contract: hidden substitution inside a named solver is prohibited; transparent, reasonable fallback at a composite/default layer is allowed. Historical candidate/default reports do not impose a solver choice.

The owner intends this responsibility split to match EllPHi's standard. This body update does not verify the existing implementation, change code or tests, launch experiments/review dispatch, or expand merge/release authorization.

Open named-method acceptance item (source check: 2026-10-05)

  • Make explicitly selected scipy-slsqp honor the named-method contract. At db5ea80ec3ee87e4bfa20bf9ba4adc46be9ade7a, the engine's SLSQP branch calls _newton_polish when SLSQP has not met its success/gap criteria and records accuracy_polish="newton" internally. The public stage construction and returned CechInfo omit that transition and identify the method as scipy-slsqp. The public interface supplies no disable switch for this polish; validation requires newton_max_iter > 0. Thus strict identity/traceability is not yet established for every named method. Explicit scipy-slsqp must either succeed within its declared method or raise a meaningful exception. Any retained SLSQP+Newton composite must be explicitly identified and externally traceable under the policy above. Verify the resulting route identity, transition diagnostics and failure behavior with focused tests; this does not require every boundary case to return a value. The existence of auto or green CI does not close this specific acceptance item. This is a source-level finding, not a new runtime experiment or an implementation prescription.

Review history

Three local pseudo-PR rounds with Codex (gpt-5.6-sol) reviews, two rounds each; findings and dispositions are recorded in the squash commit messages.

Checklist

black, black --check, flake8, mypy (src+tests), stubtest with the existing allowlist, pytest 497 passed, uv lock --check. All required local checks passed.

Closes nothing; tracked in uda-lab/project-ellphi#26.

🤖 Generated with Claude Code
https://claude.ai/code/session_01Mn94Zd2yUjWGNQX3rtd4oM

uda-lab-agent and others added 4 commits October 4, 2026 15:52
…(ported from ellcech)

Squash of local topic branch project26-port-minimax (8 commits) after two
local Codex review rounds (gpt-5.6-sol, read-only):
- round 1: REQUEST CHANGES, 3 documentation findings (contract exactness
  under regularization/conditioning; regularization scope and
  condition_number_limit guarantee; nonexistent damped-Newton fallback);
  fixed in 972ddbc (gpt-5.6-luna).
- round 2: REQUEST CHANGES, residual wording (unadjusted := regularization
  == 0 and condition_number_limit is None; outputs are approximations);
  fixed in 2ed9783. Two-round cap reached; dispositions recorded here.
No executable change relative to ellcech 82d13e3 (650-case bitwise
comparison); checklist black/flake8/mypy/stubtest/pytest(396) passes.
Names are provisional pending owner decisions in uda-lab/project-ellphi#26.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Mn94Zd2yUjWGNQX3rtd4oM
…headers

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Mn94Zd2yUjWGNQX3rtd4oM
…ngency_simplex_grad)

Squash of local topic branch project26-pairwise-contract (6 commits) after two
local Codex review rounds (gpt-5.6-sol, read-only):
- round 1: REQUEST CHANGES — blocker: engine ignores the packed constant
  term, so t/point/dt_dcoef are valid only for normalised rows; major:
  SimplexTangencyGrad field order; minor: non-finite tolerances; minor:
  right-triangle fixture assertions. Fixed in 81b311c (gpt-5.6-luna):
  per-row normalisation gate (ValueError otherwise), documented
  normalisation-preserving derivative, field order, tolerance validation.
- round 2: REQUEST CHANGES — blocker: catastrophic cancellation when
  evaluating the packed quadric at far-translated points (t from
  result.alpha, centred constraint evaluation); major: gate rejected valid
  coef_from_cov output for ill-conditioned covariances and d=1. Fixed in
  9cca0ca: conditioning-aware bound
  max(norm_tol*max(1,|c|), 64*eps*cond2(A)*max(1,|c|,|b^T A^-1 b|));
  d=1 packed conics are a pre-existing EllPHi limitation (unpack_conic),
  documented and reported with a clear error. Two-round cap reached;
  dispositions recorded here; checklist re-run independently (446 passed).
Public contract: SimplexTangencyResult(t, point, mu, support, active_set)
with active_set = tight constraints (paper sense) and support = weight
support; raises on non-convergence; SimplexTangencyGrad(t, point, mu,
dt_dcoef, support, active_set) in coef space. Engine moved to private
_minimax_python / _minimax_grad_python modules (history preserved).
General constants inside the solve are implemented on the engine branch
and will lift the normalisation gate. Names provisional (#26).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Mn94Zd2yUjWGNQX3rtd4oM
…sets) and add the public surrogate fixture

Squash of local topic branch project26-engine-hardening (7 commits) after two
local Codex review rounds (gpt-5.6-sol, read-only):
- round 1: REQUEST CHANGES — major: snapping roundoff-sized constants
  falsified the packed-coordinate gradient; major: negative engine value
  clipped to t=0 with inconsistent sets; minor: offsets not checked finite
  before the k==1 fast path; minor: incomplete deviation list; nits: empty
  face misreported, fixture provenance not reproducible. Fixed in e8a2660
  (gpt-5.6-luna): exact offsets passed through, ValueError for negative
  values beyond roundoff, finite check, deviation list, empty_face status,
  generation recipe + regeneration test.
- round 2: REQUEST CHANGES — major: negative tolerance rejected legitimate
  cancellation-scale values (centre (1e6,-1e6)); minor: post-polish Cholesky
  failure deviation missing. Fixed in cc61adc: cancellation bound
  value_roundoff = sum_i 64*eps*cond2(A_i)*max(|c_i|, |xbar_i^T A_i xbar_i|)
  carried from _prepare_coefs; deviation list completed; the 1e8 translated
  test rewritten to a well-scaled claim (packed constants carry roundoff of
  order eps*|xbar|^2; a representation limit, not a solver property).
  Two-round cap reached; dispositions recorded here; checklist re-run
  independently (481 passed).
Engine deviations from ellcech 82d13e3 are enumerated in the module
docstring: Armijo-rejected steps never applied (best iterate kept,
converged=False), face re-identification after accepted steps, undamped
Newton stops on ill-conditioned reduced Hessian, newton-cold falls back to
a fresh FW iterate (converged=False), failure statuses force
converged=False, post-polish Cholesky failure forces converged=False,
full-step Armijo roundoff allowance, additive offsets (delta_i) with
d alpha/d delta_i = mu_i. Fidelity: 3,048 legacy converged=True results
over 480 instances identical to 1e-12 (scripts/compare_minimax_engine.py,
opt-in). Public surrogate fixture (k=6, d=2, deterministic recipe) encodes
the #27 mechanism: SLSQP meets value/gap bounds, every other method raises.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Mn94Zd2yUjWGNQX3rtd4oM
@t-uda

t-uda commented Oct 4, 2026

Copy link
Copy Markdown
Owner

@codex please review this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T10:18:22.289821Z db5ea80 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.41876% with 75 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ellphi/_minimax_python.py 91.18% 55 Missing ⚠️
src/ellphi/cech.py 91.98% 17 Missing ⚠️
src/ellphi/_minimax_grad_python.py 91.89% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 50120234a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/ellphi/cech.py Resolved
Comment thread src/ellphi/cech.py Resolved
Comment thread src/ellphi/_minimax_python.py Resolved
Validate solver controls and preserve a non-empty Frank-Wolfe face. Use the regularized dual for positive-regularization SLSQP and cover all three review regressions.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Claude-Session: https://claude.ai/code/session_01Mn94Zd2yUjWGNQX3rtd4oM
@t-uda

t-uda commented Oct 4, 2026

Copy link
Copy Markdown
Owner

@codex please review this PR

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dc39c2eb9e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/ellphi/_minimax_python.py Resolved
Comment thread src/ellphi/cech.py Resolved
Comment thread src/ellphi/_minimax_python.py Resolved
Comment thread src/ellphi/_minimax_python.py Resolved
Comment thread src/ellphi/_minimax_python.py Resolved
…hResult, cech_grad)

Rename the public many-body API after the anisotropic Čech filtration. For k bodies, t^2 = alpha(sigma) is the least scale at which the growing ellipsoids share the critical point x*, where the active normals are positively dependent; the boundaries are not mutually tangent except in the pairwise k = 2 case.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Mn94Zd2yUjWGNQX3rtd4oM
@uda-lab-agent uda-lab-agent changed the title feat: many-body (simplex) tangency solver and gradient ported from ellcech feat: anisotropic Čech filtration value and gradient for ellipsoid simplices (ported from ellcech) Oct 4, 2026
@t-uda

t-uda commented Oct 4, 2026

Copy link
Copy Markdown
Owner

@codex please review this PR

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 565547a112

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/ellphi/cech.py Resolved
uda-lab-agent and others added 2 commits October 4, 2026 22:48
Thread matrix stabilization through Newton polishing and convergence checks, keep stabilized SLSQP objectives consistent, report successful FW fallbacks, and prevent thresholded-face false convergence.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Mn94Zd2yUjWGNQX3rtd4oM
Remove stabilization keywords from the public value and gradient APIs, update their stubs and guide, and cover rejected controls plus the public fallback path.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Mn94Zd2yUjWGNQX3rtd4oM
@t-uda

t-uda commented Oct 4, 2026

Copy link
Copy Markdown
Owner

@codex please review this PR

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c878998467

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/ellphi/_minimax_python.py Resolved
Comment thread src/ellphi/_minimax_python.py Resolved
Comment thread src/ellphi/_minimax_python.py Resolved
@t-uda

t-uda commented Oct 4, 2026

Copy link
Copy Markdown
Owner

@codex please review this PR

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6d0e6fe361

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/ellphi/_minimax_python.py Resolved
…ro conditioning escalations

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Mn94Zd2yUjWGNQX3rtd4oM
@t-uda

t-uda commented Oct 4, 2026

Copy link
Copy Markdown
Owner

@codex please review this PR

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9c17323384

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/ellphi/_minimax_python.py Resolved
Comment thread src/ellphi/_minimax_python.py Resolved
…lised Newton residuals

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Mn94Zd2yUjWGNQX3rtd4oM
@t-uda

t-uda commented Oct 4, 2026

Copy link
Copy Markdown
Owner

@codex please review this PR

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce78b372dc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/ellphi/cech.py Resolved
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Mn94Zd2yUjWGNQX3rtd4oM
@t-uda

t-uda commented Oct 4, 2026

Copy link
Copy Markdown
Owner

@codex please review this PR

@uda-lab-agent

Copy link
Copy Markdown
Collaborator Author

Correction to the evidence comment above: review #140 (review) on 0d60fb0 carried 1 inline comment (P2, FW donor selection under a nonzero weight_tol), answered as declared-method behaviour in #140 (comment) and resolved; it is noted as a candidate follow-up, not silently dropped. The subsequent codex pass on the same commit reported no major issues (comment 5988229921). CI: 10/10 green. Draft, unmerged.

@t-uda

t-uda commented Oct 5, 2026

Copy link
Copy Markdown
Owner

@codex please review this PR

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

An unknown error occurred
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

… alpha

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Claude-Session: https://claude.ai/code/session_01Mn94Zd2yUjWGNQX3rtd4oM
@t-uda

t-uda commented Oct 5, 2026

Copy link
Copy Markdown
Owner

@codex please review this PR

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

An unknown error occurred
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@t-uda

t-uda commented Oct 5, 2026

Copy link
Copy Markdown
Owner

@codex please review this PR

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3bf2406f38

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/ellphi/cech.py Resolved
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Claude-Session: https://claude.ai/code/session_01Mn94Zd2yUjWGNQX3rtd4oM
@t-uda

t-uda commented Oct 5, 2026

Copy link
Copy Markdown
Owner

@codex please review this PR

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

An unknown error occurred
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@t-uda

t-uda commented Oct 5, 2026

Copy link
Copy Markdown
Owner

@codex please review this PR

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a401b9c0c7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/ellphi/_minimax_python.py Resolved
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Claude-Session: https://claude.ai/code/session_01Mn94Zd2yUjWGNQX3rtd4oM
@t-uda

t-uda commented Oct 5, 2026

Copy link
Copy Markdown
Owner

@codex please review this PR

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e5a5e9148b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/ellphi/cech.py Resolved
@uda-lab-agent

Copy link
Copy Markdown
Collaborator Author

Review evidence: final Codex review 5411644179 on e5a5e91; inline-comment list count = 1. Earlier findings 4181619001 and 4181783343 were resolved in a401b9c and e5a5e91 respectively. Finding 4181899382 remains open after the two permitted fix rounds. Comparator status=complete; CI=green.

@t-uda

t-uda commented Oct 5, 2026

Copy link
Copy Markdown
Owner

@codex please review this PR

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 99a0dfa461

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/ellphi/cech.py Resolved

t-uda commented Oct 5, 2026

Copy link
Copy Markdown
Owner

Updated the PR body with the settled named-solver failure contract, transparent composite/default fallback policy and ordinary-input performance priority; value/status fidelity remains separate from derivative guarantees, and no solver choice was imposed.

uda-lab-agent added 3 commits October 5, 2026 18:21
…eclare line-search safeguard

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Claude-Session: https://claude.ai/code/session_01Mn94Zd2yUjWGNQX3rtd4oM
… fields and the auto route

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Claude-Session: https://claude.ai/code/session_01Mn94Zd2yUjWGNQX3rtd4o
@t-uda

t-uda commented Oct 5, 2026

Copy link
Copy Markdown
Owner

@codex please review this PR

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: db5ea80ec3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@uda-lab-agent

Copy link
Copy Markdown
Collaborator Author

Reviewed-by: chatgpt-codex-connector[bot] — review #140 (comment) on db5ea80: 0 inline comments.

t-uda commented Oct 5, 2026

Copy link
Copy Markdown
Owner

Added an open acceptance item to the PR body: at db5ea80, explicit scipy-slsqp can invoke Newton without exposing that transition in public diagnostics; named-method identity and traceability still need to satisfy the settled contract.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants