Repository navigation
docs(changelog): amend 1.15.0 notes for the @base-ui/react 1.6.0 → 1.8.0 bump - #562
Merged
Merged
Conversation
…8.0 bump The 1.15.0 entry for 6e4f783 said only that Base UI moved to 1.8.0. It did not give the from-version or name the two upstream behaviour changes that break consumer tests: closed `Select` no longer renders its options, and the dialog scroll lock can move a button under a Playwright coordinate click. - Amend the 1.15.0 CHANGELOG bullet with both changes and the test-side fix - Add a 1.15.0 entry to docs/migrations.md (and resync docs-manifest.json) - Add a patch changeset so the next npm CHANGELOG carries a pointer - Require from→to versions and behaviour changes for UI-foundation bumps in the create-changeset skill Refs tailor-inc/platform-planning#1945 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Code Metrics Report
Details | | main (c3e4b52) | #562 (13954bc) | +/- |
|---------------------|----------------|----------------|------|
| Coverage | 87.5% | 87.5% | 0.0% |
| Files | 206 | 206 | 0 |
| Lines | 6082 | 6082 | 0 |
| Covered | 5323 | 5323 | 0 |
+ | Test Execution Time | 2m20s | 2m13s | -7s |Reported by octocov |
IzumiSy
approved these changes
Sep 29, 2026
Resolve docs-manifest.json by regenerating it with pnpm docs:sync. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@tailor-platform/app-shell@1.15.0bumped@base-ui/reactfrom 1.6.0 to 1.8.0 (#517, commit6e4f783). Its release note said only that Base UI moved to 1.8.0. It gave no from-version and named no behaviour change, but two upstream changes break consumer tests:Selectno longer renders its options into the DOM until it is opened, so unit tests that assert option text on a closedSelectfail.Dialog/AlertDialogapplies a scroll lock that shifts layout during a Playwright click, so a coordinate click can land on the backdrop and close the dialog.This PR fixes the notes after the fact and adds a rule so the next UI-foundation bump documents this up front.
Changes
packages/core/CHANGELOG.md: amends only the6e4f783bullet in the 1.15.0 section. It now gives 1.6.0 → 1.8.0, lists both behaviour changes with the test-side fix, links to the migration entry, and ends with an italic note that the entry was amended after release. No other entry is touched.docs/migrations.md: adds a 1.15.0 row and section (applies to / what breaks / how to detect / what to change). An app that changes nothing can still fail CI after upgrading, so it belongs on this page.docs-manifest.json: hash refresh frompnpm docs:sync.docs/migrations.mdis copied into the bundled skill, and the drift gate needs this..changeset/amber-owls-listen.md: patch changeset. The CHANGELOG inside the published 1.15.0 tarball can't change, so the next release's npm CHANGELOG carries a short pointer instead..agents/skills/create-changeset/SKILL.md: new summary rule. A changeset for a UI-foundation bump (@base-ui/reactand similar) must give from→to versions and list the behaviour or test-visible changes found in the PR's snapshot diffs.No package code or version changes.
Not in this PR: ticket action 6, the version policy question (should a Base UI minor bump be an app-shell minor?). That still needs a maintainer decision.
After merge
Update the GitHub release body for
@tailor-platform/app-shell@1.15.0with the amended section. The current body is the CHANGELOG's 1.15.0 section without its heading, so extract the same range frommain:The italic "amended after release" note is part of the extracted section, so the release body carries it too.
Checks
pnpm fmt:check: clean (CHANGELOG.mdis excluded from oxfmt by.oxfmtrc.json)pnpm docs:check: no blocking issues afterpnpm docs:sync🤖 Generated with Claude Code