Skip to content

fix(sidebar): resolve localized item titles - #564

Open
IzumiSy wants to merge 1 commit into
mainfrom
fix/sidebar-item-localized-title
Open

IzumiSy wants to merge 1 commit into
mainfrom
fix/sidebar-item-localized-title

Conversation

@IzumiSy

@IzumiSy IzumiSy commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Motivation

SidebarItem.title accepted only raw strings even though SidebarGroup.title accepts localized strings. Consumers therefore could not pass defineI18nLabels values to sidebar items without resolving them inside the AppShell context.

Resolves tailor-inc/platform-planning#1887.

Summary

  • Accept LocalizedString title overrides in SidebarItem.
  • Resolve function-based overrides using the active AppShell locale while preserving existing string behavior, including empty strings.
  • Add locale and compatibility coverage, regenerate documentation, and include a patch changeset.

@github-actions

Copy link
Copy Markdown
Contributor

Code Metrics Report

main (820ddb3) #564 (81b7beb) +/-
Coverage 87.5% 87.5% +0.0%
Test Execution Time 2m19s 2m17s -2s
Details
  |                     | main (820ddb3) | #564 (81b7beb) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          87.5% |          87.5% | +0.0% |
  |   Files             |            206 |            206 |     0 |
  |   Lines             |           6078 |           6081 |    +3 |
+ |   Covered           |           5319 |           5322 |    +3 |
+ | Test Execution Time |          2m19s |          2m17s |   -2s |

Code coverage of files in pull request scope (95.4% → 96.0%, patch 100.0%)

Files Coverage +/- Patch Coverage Status
packages/core/src/components/sidebar/sidebar-item.tsx 96.0% +0.5% 100.0% modified

Reported by octocov

@IzumiSy
IzumiSy marked this pull request as ready for review September 29, 2026 08:38
@IzumiSy
IzumiSy requested a review from a team as a code owner September 29, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant