Repository navigation
net/http: say who owns the errors CrossOriginProtection returns - #719
Merged
Merged
Conversation
check-annotations wants an OWNS, BORROWS or STATIC on every function that returns an Error. AddTrustedOrigin's comes from fmt_errorf, in the goroutine's error arena, and Check's are static sentinels.
23 of 27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
The lint job fails on #716 and #717, and on main since #711. Its log shows:
The fix
http_cross_origin_protection_add_trusted_originBURROW_BORROWS(ret)fmt_errorf, which keeps them in the goroutine's error arena and is annotated the same way.http_cross_origin_protection_checkBURROW_STATIC(ret)http_csrf.c.Checks
Locally,
tools/check-annotations.shprintsok annotations 229 headers. The rest of the lint job's source checks pass too: check-banned, check-alloc, check-globals, check-statics and check-errout.http_csrf.cpasses the syntax check.