Repository navigation
net/http: skip the CrossOriginProtection server test without TCP - #720
Merged
Merged
Conversation
Windows has no TCP yet, so httptest panics on listen there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
On #717, the windows-msvc and windows-mingw jobs fail in
http_csrf_test, which came in with #711. The msvc log shows:The mingw log has the same two lines. burrow has no TCP on Windows yet, since that needs the readiness poll FD, and every other test that starts an
httptestserver skips there through aneed_tcphelper. This one didn't.The fix
tests/http_csrf_test.cgets the sameHAVE_TCPcheck andneed_tcphelper ashttp_form_test.c, andTestCrossOriginProtectionServercalls it first, before it allocates anything.Checks
The file passes the syntax check with
-Wall -Wextraand clang-format. Nothing was run, because none of the servers has 5G free, so CI's Windows jobs are the check.