Repository navigation
sections-divergences: the 7.3 differences from the decompressor, main, wakeup.c and fs/super.c - #125
Merged
Merged
Conversation
…, wakeup.c and fs/super.c
15 of 45 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change explains the section and table differences that the 7.3 compare on #110 reported with no reason. I read each one against the source and against a test compile on server3.
What changes
.note.gnu.propertyonly in the gcc objects ofarch/x86/boot/compressedanddrivers/firmware/efi/libstub. Ubuntu's gcc turns on-fcf-protectionwhen no-fcf-protectionis given, and writes the IBT and SHSTK note. These directories set their own flags without-fcf-protection. Debian's gcc and rucc write no note then. I checked this withgccandruccon a file with no flags. The EFI stub removes the note from each object..text.startuponly in the gcc objects ofarch/x86/boot/main.oandarch/x86/realmode/rm/wakemain.o. gcc putsmainthere when it optimizes. Both linker scripts collect.text.*.__bug_tablesite forWARN_ON(!ws)inwakeup_source_remove. Its only caller calls it insideif (ws), so rucc is correct to remove it..altinstructions,.altinstr_replacementand.discard.annotate_dataonly in the gccfs/super.owhenCONFIG_BUGis off. rucc deletes thepopcntalternative ofhweight32because no one reads its result. gcc keeps it because of theASM_CALL_CONSTRAINToutput on the stack pointer. The result is the same here, but in general this is a difference from GCC, so I opened Keep an asm that writes a global register variable, as gcc does with ASM_CALL_CONSTRAINT rucc#3764 with a reduction.Check
cargo test -p rkpasses, and the file parses. The kernel workflow on this PR runs the compare again on 7.3.Part of #109.