Repository navigation
List exports TRIM_UNUSED_KSYMS kept in one build only as trimmed - #189
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With CONFIG_TRIM_UNUSED_KSYMS, which allmodconfig sets, the kernel keeps an export only when some module uses it. The 7.2.8 allmodconfig census has one export the gcc-14 build has and the rucc build does not,
__x86_indirect_thunk_rbp. Both kernels define the thunk, but no rucc module calls through %rbp, so the rucc build trims the export. That follows register allocation and is not a lost export.symvers-diff now reads
.configon both sides. When both trim, an export only one build has, of a symbol both System.maps define as a global, is listed as trimmed and does not count as a difference. sections-diff leaves out.vmlinux.export.o, the object made from the export list, since its tables hold the same trimmed set and symvers-diff already compares it symbol by symbol.On census 40199212017 symvers-diff is now clean, with the thunk listed as trimmed, and the three
.vmlinux.export.orows leave the sections report.