Repository navigation
bench: a benchmark the kernel cannot run skips only itself - #194
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly bench on tinyconfig only reported 6 of the 15 benchmarks and never got to the memcpy control, so it always said the host was too noisy. tinyconfig has no
AF_UNIX, sosocketpairfailed inunix-pingpong,fail()calledexit(1)and nothing after it ran.Now
/benchforks a child for each benchmark. When a child fails it printsRK-BENCH-SKIP <name>and the next benchmark still runs. The Rust side already ignores lines that are notRK-BENCH <name> <ns>, and the console test now has a skip line in it. Plan 12.2 says the same thing.Checked on server3 with the host gcc: all 15 lines as before, and with
AF_UNIXswapped for a bad family the run printsRK-BENCH-SKIP unix-pingpongand still ends with memcpy.cargo test -p rk benchand clippy pass.Part of #9.