Repository navigation
bench: judge each ratio by the upper end of its 95% interval - #196
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan 12.2 says a benchmark is within 5% when the upper end of the 95% interval of its rucc/gcc median ratio is at most 1.05, and K8's exit criterion says the same.
rk benchonly looked at the ratio of the two medians, so one lucky run could pass a benchmark that is really slower.Bench::intervalresamples the runs of each kernel with replacement 2000 times, takes the ratio of the medians each time and keeps the 2.5th and 97.5th percentiles. The seed is fixed, so the samebench.jsonalways gives the same interval. The gate now checks the upper end of each interval instead of the ratio. The geometric mean check stays on the medians, as the exit criterion has it. The table gets a "95% interval" column.New test: equal runs give an interval of just the ratio, a spread of a few percent widens it past 1.05, and an empty bench has none.
cargo test -p rk benchand clippy pass on server3.Part of #9.