chore(cymbal): add shimforge to simplify tests - #2
Draft
tanglearncode wants to merge 314 commits into
Draft
tanglearncode wants to merge 314 commits into
tanglearncode wants to merge 314 commits into
Conversation
tanglearncode
marked this pull request as draft
September 16, 2026 05:52
Co-authored-by: releaser-posthog-cli[bot] <290815855+releaser-posthog-cli[bot]@users.noreply.github.com>
…#100112) Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com> Co-authored-by: mariusandra <53387+mariusandra@users.noreply.github.com>
…stHog#100741) Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com> Co-authored-by: Paul D'Ambra <paul@posthog.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: pauldambra <984817+pauldambra@users.noreply.github.com>
PostHog#101128) Co-authored-by: tests-posthog[bot] <250237707+tests-posthog[bot]@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…og#101087) Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com> Co-authored-by: Tue Haulund <tue@posthog.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…PostHog#101441) Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com>
…st cap (PostHog#101289) Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com> Co-authored-by: Tue Haulund <tue@posthog.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…PostHog#101031) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
…Hog#101423) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
…92325) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: andrewm4894 <2178292+andrewm4894@users.noreply.github.com>
Co-authored-by: Alex V <alexander.veryaysky@gmail.com>
Co-authored-by: tests-posthog[bot] <250237707+tests-posthog[bot]@users.noreply.github.com> Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com>
…ry row (PostHog#101498) Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com> Co-authored-by: Andrew Maguire <andrewm4894@gmail.com>
…pers (PostHog#99725) Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com>
Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com>
…og#101041) Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com> Co-authored-by: cvolzer3 <15130376+cvolzer3@users.noreply.github.com>
…uests (PostHog#101920) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com>
Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com>
Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com>
…Hog#90564) Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com> Co-authored-by: Lucas Ricoy <2034367+lricoy@users.noreply.github.com>
…ption tests (PostHog#99734) Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com>
…og#95403) Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com>
Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com> Co-authored-by: jordanm-posthog <245956587+jordanm-posthog@users.noreply.github.com>
Co-authored-by: tests-posthog[bot] <250237707+tests-posthog[bot]@users.noreply.github.com> Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com>
PostHog#91120) Co-authored-by: tests-posthog[bot] <250237707+tests-posthog[bot]@users.noreply.github.com>
…tHog#101921) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…7304) Co-authored-by: tests-posthog[bot] <250237707+tests-posthog[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com>
…1285) Co-authored-by: posthog[bot] <206114724+posthog[bot]@users.noreply.github.com>
tanglearncode
force-pushed
the
chore/cymbal-shimforge-capture-test
branch
2 times, most recently
from
September 17, 2026 04:01
44feb67 to
c1952c2
Compare
tanglearncode
force-pushed
the
chore/cymbal-shimforge-capture-test
branch
from
September 17, 2026 04:05
c1952c2 to
eeec30c
Compare
Replace the telemetry HTTP mock and its flush-and-poll loop with a thread-local shimforge mock of common_posthog::capture_exception. The test asserts the handoff directly - HTTP 500, exactly one capture, UnhandledError::SqlxError(PoolClosed), and the request_id, batch_event_count and team_count properties - instead of polling an HTTP mock for up to five seconds. Add shimforge 0.1.3 as a pinned dev-dependency with its lock entries.
tanglearncode
force-pushed
the
chore/cymbal-shimforge-capture-test
branch
from
September 17, 2026 04:07
eeec30c to
a46dcc2
Compare
🤖 CI report❌ Docs preview — preview build failed to startThe docs preview build could not be triggered. View the workflow logs for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a demo PR. Cymbal's test waits on a live HTTP mock for up to five seconds. On a busy CI runner, this could make tests flakey.
common_posthog::capture_exception, so the test checks the handoff directly instead of waiting for it to show up over HTTP.UnhandledError::SqlxError(PoolClosed)), and the rightrequest_id,batch_event_count, andteam_countproperties.