Repository navigation
Conversation
Neither job had timeout-minutes, so both inherited GitHub's 360 minute default. The same gap in nap-java let a stuck scan run for 50 minutes before I noticed, and it would have gone to six hours unattended. vitest spawns workers and the voucher suite talks to a local mint, so a child that never exits is the realistic way this hangs. Caps are sized for a hang rather than for slowness: both jobs finish in about a minute today, so 20 and 15 leave room for the suite to grow without the cap becoming the thing that fails. workflow_dispatch for the same reason it was added to nap-java. The audit job asks npm's advisory database a question whose answer changes without this repository changing, so re-checking it should not require inventing a commit. Nothing here caches on failure. `cache: npm` is managed by setup-node and restores from the registry, so it does not have nap-java's problem of an expensive artifact discarded whenever the job fails.
ci: bound every job, and allow manual runs Neither job had timeout-minutes, so both inherited GitHub's 360 minute default. The same gap in nap-java let a stuck scan run 50 minutes before anyone noticed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the CI hardening from #48 to
master, so the branch that actually receives pushes is covered too.Neither job had
timeout-minutes, so both inherited GitHub's 360 minute default. The identical gap innap-javalet a stuck scan run 50 minutes before I noticed, and it would have reached six hours unattended. Both jobs finish in about a minute today, so the caps are sized for a hang rather than for slowness.Also adds
workflow_dispatch, since the audit job asks npm's advisory database a question whose answer changes without this repository changing.No source changes. Verified green on #48 before merging to
develop.