Repository navigation
Add GitHub and Cloudflare to the default website check - #32
Merged
Merged
Conversation
Both were already in the fallback list inside network_diagnostics.py but not in the list the migrated web_check module actually uses, so neither was reached on any normal run. They are a different kind of canary from the ten consumer sites above them. A developer notices GitHub being unreachable immediately, and Cloudflare fronts a large share of the web, so Cloudflare failing while Google and Amazon still answer is itself a useful signal rather than just one more failure. Verified both answer from this machine: cloudflare.com in 0.087s and github.com in 0.221s. The list now holds nineteen sites. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
github.comandwww.cloudflare.comtoDEFAULT_WEBSITESinnetwork_tools/web_check.py, taking that list from seventeen sites to nineteen.Why these two
Both were already present in the fallback list inside
network_diagnostics.py,but not in the list the migrated
web_checkmodule actually uses. That fallbackonly runs if importing the migrated module raises, so in practice neither site
was ever reached on a normal run.
They are also a different kind of canary from the ten consumer sites above them.
A developer notices GitHub being unreachable immediately, and Cloudflare fronts
a large share of the web, so Cloudflare failing while Google and Amazon still
answer is a useful signal in itself rather than just one more failure.
Verified
Both answer from this machine:
Note for the phonebot side
phonebot narrates this tool's output, and it now names the sites that failed
rather than only counting them. It does that from its own spoken-name table,
keyed on hostname, so that no text produced by this repository reaches a
text-to-speech engine. A test on that side reads this file directly and fails if
a site here has no spoken name, so the two repositories are checked against each
other rather than assumed to agree.
Both hostnames added here already have entries on that side, including the
wwwand bare variants, so nothing is needed beyond merging this.🤖 Generated with Claude Code