Skip to content

Replace length-0 with empty character when do.call() of TDA::*Diag() is passed to as_persistence.diagram() - #58

Merged
astamm merged 3 commits into
mainfrom
docall
Oct 6, 2026
Merged

astamm merged 3 commits into
mainfrom
docall

Conversation

@corybrunson

@corybrunson corybrunson commented Jul 8, 2026 •

Copy link
Copy Markdown
Member

as_persistence.diagram() would fail when the input was obtained through do.call(); it now continues without error, but with empty information about the engine.

This problem should be more carefully handled in future; this is just a stopgap.

@astamm

astamm commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

This problem should be more carefully handled in future; this is just a stopgap.

Thanks @corybrunson! Have you filed a specific issue to keep track of this?

@astamm astamm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #54.

@astamm astamm changed the title replace length-0 with empty character when do.call of TDA::*Diag is passed to as_persistence.diagram - fixes #54 Replace length-0 with empty character when do.call of TDA::*Diag is passed to as_persistence.diagram Oct 6, 2026
@astamm astamm changed the title Replace length-0 with empty character when do.call of TDA::*Diag is passed to as_persistence.diagram Replace length-0 with empty character when do.call() of TDA::*Diag() is passed to as_persistence.diagram() Oct 6, 2026
@astamm

astamm commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Ok for me to merge once we make sure an issue keeps track of the need to come back to this later.

@corybrunson

Copy link
Copy Markdown
Member Author

Merge when ready. I need to revisit the patch to spell out what i think needs to be done in future; i'll open an issue soon about that.

@astamm
astamm merged commit 8bb9631 into main Oct 6, 2026
10 checks passed
@astamm
astamm deleted the docall branch October 6, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants