Repository navigation
Merged
Conversation
…assed to as_persistence.diagram - fixes #54
Collaborator
Thanks @corybrunson! Have you filed a specific issue to keep track of this? |
astamm
reviewed
Oct 6, 2026
do.call() of TDA::*Diag() is passed to as_persistence.diagram()
Collaborator
|
Ok for me to merge once we make sure an issue keeps track of the need to come back to this later. |
Member
Author
|
Merge when ready. I need to revisit the patch to spell out what i think needs to be done in future; i'll open an issue soon about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as_persistence.diagram()would fail when the input was obtained throughdo.call(); it now continues without error, but with empty information about the engine.This problem should be more carefully handled in future; this is just a stopgap.