fix: prevent path traversal through hashed asset routes - #833
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unauthenticated requests to the hashed asset routes could read files outside
public/through raw or URL-encoded traversal paths. Validate decoded filename components and check that the resolved path stays inside the selected asset directory before serving it. Invalid paths return 404; valid assets retain immutable caching.Regression tests execute the production route with temporary files and cover both asset directories, encoded traversal, sibling-directory escapes, valid assets, missing assets, and static fallback. Before the fix, 10 traversal cases returned 200 instead of 404.
Validation: