Repository navigation
fix: prevent large notebook download timeouts - #835
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large notebooks can exceed the anonymization deadline when a configured literal name occurs anywhere in their contents, breaking both the viewer and file downloads. Repository ZIP downloads also need to release every active stream when processing fails or the client disconnects.
Search literal candidates natively and validate each match with RE2 on a small surrounding window, preserving case folding and boundary behavior. Cancel the ZIP parser and active entry transformers along with the upstream download and archive. Synthetic regression tests cover a 48 MiB notebook, names before and after its output, Unicode boundaries, ZIP completion, anonymization failures, and disconnects.
Validation: UI build passes; 658 tests pass, 49 pending; lint has no errors and seven existing warnings. Type checking passes with ES2022 target/library overrides; the default configuration has existing target/library errors. A local 48 MiB reproduction improved from exceeding the one-second deadline to approximately 55 ms.