Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser consent requests need the current signed-in owner session, CSRF protection and bounded input. Add an unwired Express router that reloads session authority, derives session-bound CSRF tokens without rewriting sessions, validates exact payloads, and cancels pending previews on disconnect. It omits internal owner/repository identifiers from confirmation responses.
Validation: 12 targeted cases include a CSRF/logout race, incomplete uploads, cancellation and the 15-second deadline. The broader local suite passes 723 cases with 63 opt-in/environment-dependent cases pending; TypeScript and lint pass. Fifty synthetic HTTP previews measure median 4.51 ms and p95 7.26 ms, excluding MongoDB/provider latency. CI runs this suite with the consent database tests and retains both performance reports.
Stacked on #845. Startup mounting/order, private configuration, browser UI, binding exchange and activation remain pending. Capabilities remain unchanged. The documentation also clarifies that the earlier database benchmark log did not establish its underlying error.