Skip to content

Protect artifact consent HTTP requests with current sessions and CSRF - #846

Open
tdurieux wants to merge 1 commit into
codex/review-owner-consentfrom
codex/review-consent-http
Open

tdurieux wants to merge 1 commit into
codex/review-owner-consentfrom
codex/review-consent-http

Conversation

@tdurieux

Copy link
Copy Markdown
Owner

Browser consent requests need the current signed-in owner session, CSRF protection and bounded input. Add an unwired Express router that reloads session authority, derives session-bound CSRF tokens without rewriting sessions, validates exact payloads, and cancels pending previews on disconnect. It omits internal owner/repository identifiers from confirmation responses.

Validation: 12 targeted cases include a CSRF/logout race, incomplete uploads, cancellation and the 15-second deadline. The broader local suite passes 723 cases with 63 opt-in/environment-dependent cases pending; TypeScript and lint pass. Fifty synthetic HTTP previews measure median 4.51 ms and p95 7.26 ms, excluding MongoDB/provider latency. CI runs this suite with the consent database tests and retains both performance reports.

Stacked on #845. Startup mounting/order, private configuration, browser UI, binding exchange and activation remain pending. Capabilities remain unchanged. The documentation also clarifies that the earlier database benchmark log did not establish its underlying error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant