Fix dead scan buttons: frontend event aliases + runtime_store kwarg - #232
Merged
Conversation
The frontend emits start_quick_scan / start_complete_scan / start_dragnet_scan but the Flask runtime only handled a generic 'start_scan' — so the Quick Scan / Complete+PDF / Dragnet buttons were dead on the primary webshell. Adds handlers for all three names routed through a shared _start_scan_core. Also fixes start_scan_task rejecting the runtime_store kwarg that build_scan_task_deps passes (TypeError killed every scan at launch). Verified live: UI click now runs nmap -sn + vulners deep pass, CVEs are detected and recorded.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two functional bugs found during live end-to-end testing of the Flask webshell:
Dead scan buttons: the frontend emits
start_quick_scan/start_complete_scan/start_dragnet_scan, but the Flask runtime only handled a genericstart_scanevent — so the Quick Scan, Complete+PDF, and Dragnet buttons silently did nothing on the primary webshell. Adds handlers for all three names, routed through a shared_start_scan_core(same validation/rate-limit/job-registry path asstart_scan).Every scan crashed at launch:
start_scan_taskrejected theruntime_storekwarg thatbuild_scan_task_depspasses (TypeError: got an unexpected keyword argument 'runtime_store'). The wrapper now accepts and forwards it to the impl (which already supports it).Verification
Live headless test against a running server: UI click on Quick Scan with target 127.0.0.1/32 now runs
nmap -sn+ the vulners deep pass, detects CVEs (e.g. CVE-2024-47850 score 7.5), records the scan in history, and updates the discovery table (quick-hosts = 1).No new test failures vs baseline (16 pre-existing).