Skip to content

fix(openshift): handle missing TektonConfig during TLS resolution - #4067

Open
wangyusheng1985 wants to merge 1 commit into
tektoncd:mainfrom
wangyusheng1985:repo-agent/0a318cdc-auto
Open

fix(openshift): handle missing TektonConfig during TLS resolution#4067
wangyusheng1985 wants to merge 1 commit into
tektoncd:mainfrom
wangyusheng1985:repo-agent/0a318cdc-auto

Conversation

@wangyusheng1985

Copy link
Copy Markdown

Changes

Make OpenShift component TLS configuration resolution safe when the optional TektonConfig object is absent. A Kubernetes API NotFound result or a nil lister object now produces no TLS environment variables and no retry-triggering error; other lister errors continue to propagate.

Submitter Checklist

  • Includes focused regression tests
  • Updated nearby behavior documentation
  • No API or dependency changes

Validation

  • gofmt -d pkg/reconciler/openshift/common/tlsprofile.go pkg/reconciler/openshift/common/tlsprofile_test.go && git diff --check
  • go test ./pkg/reconciler/openshift/common
  • go test -race ./pkg/reconciler/openshift/common
NONE

Validation observed for this change:

  • gofmt -d pkg/reconciler/openshift/common/tlsprofile.go pkg/reconciler/openshift/common/tlsprofile_test.go && git diff --check
  • go test ./pkg/reconciler/openshift/common
  • go test -race ./pkg/reconciler/openshift/common

Signed-off-by: wangyusheng1985 <wangyusheng1985@users.noreply.github.com>
@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesnt merit a release note. labels Sep 9, 2026
@tekton-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign pratap0007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @pratap0007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla

linux-foundation-easycla Bot commented Sep 9, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: wangyusheng1985 / name: wangyusheng1985 (7dc79d7)

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 9, 2026
@jkhelil

jkhelil commented Sep 10, 2026

Copy link
Copy Markdown
Member

Hi @wangyusheng1985, thank you for your first contribution we really appreciate it!
Could you please explain how you came across this issue and raised this PR? Did you encounter this bug in a real-world scenario while running Tekton Operator?
Since this function is specifically related to OpenShift, could you also provide some evidence or steps showing that the change resolves the issue?

@wangyusheng1985
wangyusheng1985 marked this pull request as ready for review September 11, 2026 07:57
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants