fix(openshift): handle missing TektonConfig during TLS resolution - #4067
fix(openshift): handle missing TektonConfig during TLS resolution#4067wangyusheng1985 wants to merge 1 commit into
Conversation
Signed-off-by: wangyusheng1985 <wangyusheng1985@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
|
Hi @wangyusheng1985, thank you for your first contribution we really appreciate it! |
Changes
Make OpenShift component TLS configuration resolution safe when the optional TektonConfig object is absent. A Kubernetes API NotFound result or a nil lister object now produces no TLS environment variables and no retry-triggering error; other lister errors continue to propagate.
Submitter Checklist
Validation
gofmt -d pkg/reconciler/openshift/common/tlsprofile.go pkg/reconciler/openshift/common/tlsprofile_test.go && git diff --checkgo test ./pkg/reconciler/openshift/commongo test -race ./pkg/reconciler/openshift/commonValidation observed for this change:
gofmt -d pkg/reconciler/openshift/common/tlsprofile.go pkg/reconciler/openshift/common/tlsprofile_test.go && git diff --checkgo test ./pkg/reconciler/openshift/commongo test -race ./pkg/reconciler/openshift/common