fix: add resource limits - #418
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
=======================================
Coverage 50.40% 50.40%
=======================================
Files 19 19
Lines 2113 2113
=======================================
Hits 1065 1065
Misses 916 916
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks for the benchmark numbers @infernus01 🙇♀️ But I am not convinced the limits directly set in the deployment manifests. As per the table above, Memory scales linearly with resident PipelineRuns (~13.6MB/1000), so the "correct" limit is a function of the user's cluster, not something we can know upstream. Whatever number we pick will OOMKill somebody. Also, if the target namespace has a LimitRange whose we could move the benchmark table into the docs as sizing guidance, so users know what to set for their own scale @tektoncd/operator-maintainers - Request your guidance on this. Are we planning to enforce this config pattern across all tekton components individually or Shall we manage this with operator as default config values that could be overwritten. |
|
/kind bug |
0b91fac to
fcfc274
Compare
Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
3a4dadc to
b48ba7b
Compare
Relates to: #103
Summary
Updates the default resource limits in pruner manifests to align with actual measured usage from benchmark testing. The previous limits were too
conservative for the controller (512Mi) and could cause OOMKills under moderate load.
Benchmark Data
Conducted load testing on a cluster with varying numbers of completed PipelineRuns:
Key findings:
Operator Integration
These upstream manifest values serve as the baseline. The tektoncd/operator applies these limits when deploying pruner, with override capability
via:
A companion PR in tektoncd/operator would add a transformer to ensure these limits are applied
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes