Repository navigation
fix(ci): skip packages with no release yet when finding released packages - #120
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Release workflow has failed on every push to main since #111. Its
discover-releasestep reads each configured package's version from.release-please-manifest.jsonwithjq -e, andpackages/cliis configured but has no manifest entry until its first release, because it starts frominitial-version.jq -eexits 1 on the missing entry, so the step stops without a message, even on pushes that release nothing.The step now skips a package with no manifest entry, since it has no tag or release to publish yet. If release-please reports a released path that is still missing from the manifest, the existing check that every released path matches a configured package still fails the run.
The release tests add an unreleased package to the configuration and check that discovery still selects the released packages. Without this change that case fails.