Support AWS AgentCore Compute Provider - #1177
Conversation
|
|
60c6b12 to
7b7c3c3
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b7c3c37f6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| func (c *ComputeConfigArgs) hasAwsAgentcoreArgs() bool { | ||
| return c.awsAgentcoreEndpointArn != "" || | ||
| c.awsAgentcoreAssumeRoleArn != "" || | ||
| c.awsAgentcoreAssumeRoleExternalId != "" |
There was a problem hiding this comment.
Include the AgentCore skip flag in provider detection
When --aws-agentcore-skip-role-and-external-id is supplied without an AgentCore endpoint, this helper reports that no AgentCore arguments were provided. Consequently, combinations such as --remove --aws-agentcore-skip-role-and-external-id perform the removal instead of triggering the documented incompatibility check, while combining the flag with Lambda or Cloud Run silently ignores it rather than rejecting mixed providers. Include the boolean flag in this presence check so every explicitly supplied AgentCore option participates in validation.
Useful? React with 👍 / 👎.
7b7c3c3 to
8ee7818
Compare
This adds support for new AWS compute provider: AWS AgentCore. AgentCore configuration is almost identitical to AWS Lambda, replacing function ARN with Runtime Endpoint ARN.
8ee7818 to
c46046b
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c46046bf36
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "--aws-lambda-function-arn", endpointARN2, | ||
| "--aws-lambda-assume-role-arn", assumeRoleARN2, | ||
| "--aws-lambda-assume-role-external-id", assumeRoleExternalID, |
There was a problem hiding this comment.
Use AgentCore flags in the AgentCore update test
When this test is enabled after AgentCore fixtures become available, the update step uses Lambda flags and therefore switches the version from AgentCore to Lambda instead of exercising the new AgentCore update path. The test could pass while --aws-agentcore-* updates are broken; use the AgentCore endpoint and role flags here.
Useful? React with 👍 / 👎.
Related issues
n/a
What changed?
This adds support for new AWS compute provider: AWS AgentCore. AgentCore
configuration is almost identitical to AWS Lambda, replacing function
ARN with Runtime Endpoint ARN.
Checklist
Stability
-o json/-o jsonl) are treated as breaking changesDesign
temporal <noun> <verb>structure (e.g.temporal workflow start)--search-attribute, bad:--index-field)(Experimental)incommands.yamlHelp text (see style guide at the top of
commands.yaml)--namespace, not-n), one flag per lineYourXxxform (YourWorkflowId,YourNamespace)Behavior
Tests
SharedServerSuite)func TestXxx) where applicableManual tests
setup
Happy Path
Error case