fix(client): handle time skipping server long poll response - #506
Merged
Conversation
chris-olszewski
marked this pull request as ready for review
July 30, 2026 18:02
Sushisource
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Catch iteration error when fetching workflow results and continue calling.
Why?
Timeskipping server can return both no events and no continuation token during long polls.
Checklist
Closes [Bug] WorkflowHandle#result silently returns nil for a still-running workflow when the history long poll expires #499
How was this tested:
Added test with mocked empty history.
Any docs updates needed?
N/A